From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 01/18] pcap: Introduce pcap_frame() helper
Date: Fri, 9 Dec 2022 16:42:11 +1100 [thread overview]
Message-ID: <20221209054228.4085990-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20221209054228.4085990-1-david@gibson.dropbear.id.au>
pcap(), pcapm() and pcapmm() duplicate some code, for the actual writing
to the capture file. The main purpose pf pcapm() and pcampp() not calling
pcap seems to be to avoid repeatedly calling gettimeofday(). We can
accomplish that while still sharing code by adding a new helper which
takes the packet timestamp as a parameter.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
pcap.c | 59 +++++++++++++++++++++++-----------------------------------
1 file changed, 23 insertions(+), 36 deletions(-)
diff --git a/pcap.c b/pcap.c
index 836688d..c9ac5cf 100644
--- a/pcap.c
+++ b/pcap.c
@@ -65,6 +65,24 @@ struct pcap_pkthdr {
uint32_t len;
};
+/**
+ * pcap_frame() - Capture a single frame to pcap file with given timestamp
+ * @pkt: Pointer to data buffer, including L2 headers
+ * @len: L2 packet length
+ * @tv: Timestamp
+ */
+static void pcap_frame(const char *pkt, size_t len, const struct timeval *tv)
+{
+ struct pcap_pkthdr h;
+
+ h.tv_sec = tv->tv_sec;
+ h.tv_usec = tv->tv_usec;
+ h.caplen = h.len = len;
+
+ if (write(pcap_fd, &h, sizeof(h)) < 0 || write(pcap_fd, pkt, len) < 0)
+ debug("Cannot log packet, length %lu", len);
+}
+
/**
* pcap() - Capture a single frame to pcap file
* @pkt: Pointer to data buffer, including L2 headers
@@ -72,19 +90,13 @@ struct pcap_pkthdr {
*/
void pcap(const char *pkt, size_t len)
{
- struct pcap_pkthdr h;
struct timeval tv;
if (pcap_fd == -1)
return;
gettimeofday(&tv, NULL);
- h.tv_sec = tv.tv_sec;
- h.tv_usec = tv.tv_usec;
- h.caplen = h.len = len;
-
- if (write(pcap_fd, &h, sizeof(h)) < 0 || write(pcap_fd, pkt, len) < 0)
- debug("Cannot log packet, length %lu", len);
+ pcap_frame(pkt, len, &tv);
}
/**
@@ -93,8 +105,6 @@ void pcap(const char *pkt, size_t len)
*/
void pcapm(const struct msghdr *mh)
{
- struct pcap_pkthdr h;
- struct iovec *iov;
struct timeval tv;
unsigned int i;
@@ -102,24 +112,12 @@ void pcapm(const struct msghdr *mh)
return;
gettimeofday(&tv, NULL);
- h.tv_sec = tv.tv_sec;
- h.tv_usec = tv.tv_usec;
for (i = 0; i < mh->msg_iovlen; i++) {
- iov = &mh->msg_iov[i];
-
- h.caplen = h.len = iov->iov_len - 4;
+ const struct iovec *iov = &mh->msg_iov[i];
- if (write(pcap_fd, &h, sizeof(h)) < 0)
- goto fail;
- if (write(pcap_fd, (char *)iov->iov_base + 4,
- iov->iov_len - 4) < 0)
- goto fail;
+ pcap_frame((char *)iov->iov_base + 4, iov->iov_len - 4, &tv);
}
-
- return;
-fail:
- debug("Cannot log packet, length %lu", iov->iov_len - 4);
}
/**
@@ -128,7 +126,6 @@ fail:
*/
void pcapmm(const struct mmsghdr *mmh, unsigned int vlen)
{
- struct pcap_pkthdr h;
struct iovec *iov;
struct timeval tv;
unsigned int i, j;
@@ -137,8 +134,6 @@ void pcapmm(const struct mmsghdr *mmh, unsigned int vlen)
return;
gettimeofday(&tv, NULL);
- h.tv_sec = tv.tv_sec;
- h.tv_usec = tv.tv_usec;
for (i = 0; i < vlen; i++) {
const struct msghdr *mh = &mmh[i].msg_hdr;
@@ -146,18 +141,10 @@ void pcapmm(const struct mmsghdr *mmh, unsigned int vlen)
for (j = 0; j < mh->msg_iovlen; j++) {
iov = &mh->msg_iov[j];
- h.caplen = h.len = iov->iov_len - 4;
-
- if (write(pcap_fd, &h, sizeof(h)) < 0)
- goto fail;
- if (write(pcap_fd, (char *)iov->iov_base + 4,
- iov->iov_len - 4) < 0)
- goto fail;
+ pcap_frame((char *)iov->iov_base + 4, iov->iov_len - 4,
+ &tv);
}
}
- return;
-fail:
- debug("Cannot log packet, length %lu", iov->iov_len - 4);
}
/**
--
@@ -65,6 +65,24 @@ struct pcap_pkthdr {
uint32_t len;
};
+/**
+ * pcap_frame() - Capture a single frame to pcap file with given timestamp
+ * @pkt: Pointer to data buffer, including L2 headers
+ * @len: L2 packet length
+ * @tv: Timestamp
+ */
+static void pcap_frame(const char *pkt, size_t len, const struct timeval *tv)
+{
+ struct pcap_pkthdr h;
+
+ h.tv_sec = tv->tv_sec;
+ h.tv_usec = tv->tv_usec;
+ h.caplen = h.len = len;
+
+ if (write(pcap_fd, &h, sizeof(h)) < 0 || write(pcap_fd, pkt, len) < 0)
+ debug("Cannot log packet, length %lu", len);
+}
+
/**
* pcap() - Capture a single frame to pcap file
* @pkt: Pointer to data buffer, including L2 headers
@@ -72,19 +90,13 @@ struct pcap_pkthdr {
*/
void pcap(const char *pkt, size_t len)
{
- struct pcap_pkthdr h;
struct timeval tv;
if (pcap_fd == -1)
return;
gettimeofday(&tv, NULL);
- h.tv_sec = tv.tv_sec;
- h.tv_usec = tv.tv_usec;
- h.caplen = h.len = len;
-
- if (write(pcap_fd, &h, sizeof(h)) < 0 || write(pcap_fd, pkt, len) < 0)
- debug("Cannot log packet, length %lu", len);
+ pcap_frame(pkt, len, &tv);
}
/**
@@ -93,8 +105,6 @@ void pcap(const char *pkt, size_t len)
*/
void pcapm(const struct msghdr *mh)
{
- struct pcap_pkthdr h;
- struct iovec *iov;
struct timeval tv;
unsigned int i;
@@ -102,24 +112,12 @@ void pcapm(const struct msghdr *mh)
return;
gettimeofday(&tv, NULL);
- h.tv_sec = tv.tv_sec;
- h.tv_usec = tv.tv_usec;
for (i = 0; i < mh->msg_iovlen; i++) {
- iov = &mh->msg_iov[i];
-
- h.caplen = h.len = iov->iov_len - 4;
+ const struct iovec *iov = &mh->msg_iov[i];
- if (write(pcap_fd, &h, sizeof(h)) < 0)
- goto fail;
- if (write(pcap_fd, (char *)iov->iov_base + 4,
- iov->iov_len - 4) < 0)
- goto fail;
+ pcap_frame((char *)iov->iov_base + 4, iov->iov_len - 4, &tv);
}
-
- return;
-fail:
- debug("Cannot log packet, length %lu", iov->iov_len - 4);
}
/**
@@ -128,7 +126,6 @@ fail:
*/
void pcapmm(const struct mmsghdr *mmh, unsigned int vlen)
{
- struct pcap_pkthdr h;
struct iovec *iov;
struct timeval tv;
unsigned int i, j;
@@ -137,8 +134,6 @@ void pcapmm(const struct mmsghdr *mmh, unsigned int vlen)
return;
gettimeofday(&tv, NULL);
- h.tv_sec = tv.tv_sec;
- h.tv_usec = tv.tv_usec;
for (i = 0; i < vlen; i++) {
const struct msghdr *mh = &mmh[i].msg_hdr;
@@ -146,18 +141,10 @@ void pcapmm(const struct mmsghdr *mmh, unsigned int vlen)
for (j = 0; j < mh->msg_iovlen; j++) {
iov = &mh->msg_iov[j];
- h.caplen = h.len = iov->iov_len - 4;
-
- if (write(pcap_fd, &h, sizeof(h)) < 0)
- goto fail;
- if (write(pcap_fd, (char *)iov->iov_base + 4,
- iov->iov_len - 4) < 0)
- goto fail;
+ pcap_frame((char *)iov->iov_base + 4, iov->iov_len - 4,
+ &tv);
}
}
- return;
-fail:
- debug("Cannot log packet, length %lu", iov->iov_len - 4);
}
/**
--
2.38.1
next prev parent reply other threads:[~2022-12-09 5:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 5:42 [PATCH v2 00/18] RFC: Unify and simplify tap send path David Gibson
2022-12-09 5:42 ` David Gibson [this message]
2023-01-04 17:45 ` [PATCH v2 01/18] pcap: Introduce pcap_frame() helper Stefano Brivio
2023-01-05 4:47 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 02/18] pcap: Replace pcapm() with pcap_multiple() David Gibson
2022-12-09 5:42 ` [PATCH v2 03/18] tcp: Combine two parts of passt tap send path together David Gibson
2022-12-09 5:42 ` [PATCH v2 04/18] tcp: Don't keep compute total bytes in a message until we need it David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:48 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 05/18] tcp: Improve interface to tcp_l2_buf_flush() David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:53 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 06/18] tcp: Combine two parts of pasta tap send path together David Gibson
2022-12-09 5:42 ` [PATCH v2 07/18] tap, tcp: Move tap send path to tap.c David Gibson
2022-12-09 5:42 ` [PATCH v2 08/18] util: Introduce hton*_constant() in place of #ifdefs David Gibson
2022-12-09 5:42 ` [PATCH v2 09/18] tcp, udp: Use named field initializers in iov_init functions David Gibson
2022-12-09 5:42 ` [PATCH v2 10/18] util: Parameterize ethernet header initializer macro David Gibson
2022-12-09 5:42 ` [PATCH v2 11/18] tcp: Remove redundant and incorrect initialization from *_iov_init() David Gibson
2022-12-09 5:42 ` [PATCH v2 12/18] tcp: Consolidate calculation of total frame size David Gibson
2022-12-09 5:42 ` [PATCH v2 13/18] tap: Add "tap headers" abstraction David Gibson
2022-12-09 5:42 ` [PATCH v2 14/18] tcp: Use abstracted tap header David Gibson
2022-12-09 5:42 ` [PATCH v2 15/18] tap: Use different io vector bases depending on tap type David Gibson
2022-12-09 5:42 ` [PATCH v2 16/18] udp: Use abstracted tap header David Gibson
2022-12-09 5:42 ` [PATCH v2 17/18] udp: Use tap_send_frames() David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:54 ` David Gibson
2022-12-09 5:42 ` [PATCH v2 18/18] tap: Improve handling of partial frame sends David Gibson
2023-01-04 17:45 ` Stefano Brivio
2023-01-05 4:57 ` David Gibson
2023-01-04 17:45 ` [PATCH v2 00/18] RFC: Unify and simplify tap send path Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221209054228.4085990-2-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).