From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 0/8] Don't use additional sockets for receiving "spliced" UDP communications
Date: Fri, 16 Dec 2022 01:58:25 +0100 [thread overview]
Message-ID: <20221216015825.05c71cf0@elisabeth> (raw)
In-Reply-To: <20221215013018.1556807-1-david@gibson.dropbear.id.au>
On Thu, 15 Dec 2022 12:30:10 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> At present, the UDP "splice" and "tap" paths are quite separate. We
> have separate sockets to receive packets bound for the tap and splice
> paths. This leads to some code duplication, and extra open sockets.
>
> This series partially unifies the two paths, allowing us to use a
> single (host side) socket, bound to 0.0.0.0 or :: to receive packets
> for both cases.
>
> This is based on my earlier series with some fixes for the tap path.
>
> Changes since v1:
> * Renamed udp_localname[46] to udp[46]_localname
> * Allow handling of UDP port 0
> * Fix a bug which could misidentify certain v6 packets as v4-spliceable
> * Some minor cosmetic fixes to code and commit messages
It looks good to me now, thanks. I'm still trying to figure out the
throughput (to tap) topic before applying -- results look pretty much
the same now, but I'm not sure why, and I'd like to have a second
look at perf(1) statistics.
--
Stefano
prev parent reply other threads:[~2022-12-16 0:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 1:30 [PATCH v2 0/8] Don't use additional sockets for receiving "spliced" UDP communications David Gibson
2022-12-15 1:30 ` [PATCH v2 1/8] udp: Move sending pasta tap frames to the end of udp_sock_handler() David Gibson
2022-12-15 1:30 ` [PATCH v2 2/8] udp: Split sending to passt tap interface into separate function David Gibson
2022-12-15 1:30 ` [PATCH v2 3/8] udp: Split receive from preparation and send in udp_sock_handler() David Gibson
2022-12-15 1:30 ` [PATCH v2 4/8] udp: Receive multiple datagrams at once on the pasta sock->tap path David Gibson
2022-12-15 1:30 ` [PATCH v2 5/8] udp: Pre-populate msg_names with local address David Gibson
2022-12-15 1:30 ` [PATCH v2 6/8] udp: Unify udp_sock_handler_splice() with udp_sock_handler() David Gibson
2022-12-15 1:30 ` [PATCH v2 7/8] udp: Decide whether to "splice" per datagram rather than per socket David Gibson
2022-12-15 1:30 ` [PATCH v2 8/8] udp: Don't use separate sockets to listen for spliced packets David Gibson
2022-12-16 0:58 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221216015825.05c71cf0@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).