From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 769695A005E for ; Fri, 16 Dec 2022 01:58:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671152312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AKE9p5sog8zT4Mq07/mrqUptVNb7gUZZ/NNkioX04sU=; b=Kb3JVOBkjEBXGhOXjPvkD4na/gSohI73mSKnw642LW3KPJdvkfitY6FajC//MHmI7F8SXT gwY2/5lDKidLRBjx0mGPqQssd/QpYNUAsniDcwj2Y156ritpH1hZQV7FNiw+mToUKh0hb6 W6FuyDiQbrmX6EAfJ34hfDkUoomtI/8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-Ug6w8SaTMp-wZP_TWTAi2A-1; Thu, 15 Dec 2022 19:58:29 -0500 X-MC-Unique: Ug6w8SaTMp-wZP_TWTAi2A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CE09B185A78B; Fri, 16 Dec 2022 00:58:28 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-4.brq.redhat.com [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6AA14400F58; Fri, 16 Dec 2022 00:58:28 +0000 (UTC) Date: Fri, 16 Dec 2022 01:58:25 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/8] Don't use additional sockets for receiving "spliced" UDP communications Message-ID: <20221216015825.05c71cf0@elisabeth> In-Reply-To: <20221215013018.1556807-1-david@gibson.dropbear.id.au> References: <20221215013018.1556807-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: V7AOPASLEIW7J7KOYWBCKYKIJZJWZSWK X-Message-ID-Hash: V7AOPASLEIW7J7KOYWBCKYKIJZJWZSWK X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 15 Dec 2022 12:30:10 +1100 David Gibson wrote: > At present, the UDP "splice" and "tap" paths are quite separate. We > have separate sockets to receive packets bound for the tap and splice > paths. This leads to some code duplication, and extra open sockets. > > This series partially unifies the two paths, allowing us to use a > single (host side) socket, bound to 0.0.0.0 or :: to receive packets > for both cases. > > This is based on my earlier series with some fixes for the tap path. > > Changes since v1: > * Renamed udp_localname[46] to udp[46]_localname > * Allow handling of UDP port 0 > * Fix a bug which could misidentify certain v6 packets as v4-spliceable > * Some minor cosmetic fixes to code and commit messages It looks good to me now, thanks. I'm still trying to figure out the throughput (to tap) topic before applying -- results look pretty much the same now, but I'm not sure why, and I'd like to have a second look at perf(1) statistics. -- Stefano