From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 0976F5A026A for ; Wed, 4 Jan 2023 18:45:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672854343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qoGgtYti1aewLDuyYMf0jfUcXHyTcoUvxV0RchEcrIg=; b=BxfrsiRSTmVr4NjaxTJQoU71VpLaG+saWw4WxWn+np0s+1cONKlhi+EA5kmIssLCqec76R TLwiuyev77WenPmo4bc2eH+b6hZ9G0LqibQ2XBF4tP6aTo+k8dojfuOrwfxRXtHUsnHJQo ouWRUJeXhJuddWYoplqhfSL9VbKlCSQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-dEJh5MmzP0KQ2BxLXi8vOQ-1; Wed, 04 Jan 2023 12:45:41 -0500 X-MC-Unique: dEJh5MmzP0KQ2BxLXi8vOQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 939DF38149B4; Wed, 4 Jan 2023 17:45:41 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-4.brq.redhat.com [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AA011121314; Wed, 4 Jan 2023 17:45:41 +0000 (UTC) Date: Wed, 4 Jan 2023 18:45:38 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 00/18] RFC: Unify and simplify tap send path Message-ID: <20230104184538.31ce176a@elisabeth> In-Reply-To: <20221209054228.4085990-1-david@gibson.dropbear.id.au> References: <20221209054228.4085990-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: LZ5PKOJXS23TV6COQVJEZEKISYXGHS6N X-Message-ID-Hash: LZ5PKOJXS23TV6COQVJEZEKISYXGHS6N X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 9 Dec 2022 16:42:10 +1100 David Gibson wrote: > Although we have an abstraction for the "slow path" (DHCP, NDP) guest > bound packets, the TCP and UDP forwarding paths write directly to the > tap fd. However, it turns out how they send frames to the tap device > is more similar than it originally appears. > > This series unifies the low-level tap send functions for TCP and UDP, > and makes some clean ups along the way. > > This is based on my earlier outstanding series. Other than the minor remarks I shared, this looks good to me, and it shows no functional or performance impact in tests. -- Stefano