From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 4C9F25A0082 for ; Thu, 5 Jan 2023 22:50:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672955408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oAwqezi6P/H2xPp9fN1Ca/IVMgWUL72Yv+9l3r1FOBI=; b=DduWvgDIbNH0F9MLNnaGWS6ag/gUHydtBKF70AfGrKMWCcETpVW2i6B/BGaO6us6pN0mrP PveGhfgsSAOL8yiqU4aGnchHTYhiOM3SDT7CMVBtIN2sP/XI1xlfcu0NNjR40cXWmr4qhc rpuawoIMRYu9EJznntVxswrfDlBrCJk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-199-Uyt7vf8jNaafFKXviwgaQA-1; Thu, 05 Jan 2023 16:50:06 -0500 X-MC-Unique: Uyt7vf8jNaafFKXviwgaQA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70F9685C07D; Thu, 5 Jan 2023 21:50:06 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-4.brq.redhat.com [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 187F7492B06; Thu, 5 Jan 2023 21:50:05 +0000 (UTC) Date: Thu, 5 Jan 2023 22:50:03 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v4 0/8] Don't use additional sockets for receiving "spliced" UDP communications Message-ID: <20230105225003.023e4e66@elisabeth> In-Reply-To: <20230105042625.1981812-1-david@gibson.dropbear.id.au> References: <20230105042625.1981812-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BZ67TDWRFXBS2FV6B6F6CVXFY4UNCGHG X-Message-ID-Hash: BZ67TDWRFXBS2FV6B6F6CVXFY4UNCGHG X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 5 Jan 2023 15:26:17 +1100 David Gibson wrote: > At present, the UDP "splice" and "tap" paths are quite separate. We > have separate sockets to receive packets bound for the tap and splice > paths. This leads to some code duplication, and extra open sockets. > > This series partially unifies the two paths, allowing us to use a > single (host side) socket, bound to 0.0.0.0 or :: to receive packets > for both cases. > > Changes since v3: > * Fixed really dumb compile error, and actually ran through the tests. > Oops. > Changes since v2: > * Don't receive multiple packets at once for pasta mode - seems to > hurt throughput on balance. > * Add some comments clarifying reasoning here. > Changes since v1: > * Renamed udp_localname[46] to udp[46]_localname > * Allow handling of UDP port 0 > * Fix a bug which could misidentify certain v6 packets as v4-spliceable > * Some minor cosmetic fixes to code and commit messages Thanks, this looks good to me now, and I'm trying to run the tests before applying it, but for some reason they get invariably stuck at perf/passt_udp in the host to guest throughput test. I think it has nothing to do with this series, and it's rather related to the "new" suspected virtio-net TX timeout issue we started hitting a while ago, I still need to play with kernel version/workarounds etc. I'll keep you posted. -- Stefano