From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id E40A95A005E for ; Fri, 13 Jan 2023 01:07:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673568477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EpZICNijpmSpeA8Iv9XB4d8xzcrBgj8zBVDB3GjtXyo=; b=g48KSObN75wIQBMhPJcZt85iNgTnoEsqof411ToYRAm0JHGERu24y6DHNbEqVPxcIkv0X6 L2ItrtKaleGN1+hmEHtFU9SpIktveT3yZJzWn9CBwZPukXTCZIHM7oUPZ5+k2ioeHILZBI jEoNZZKxq4iuqDPLyCsesKtDr3Ei6pM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-120-ZHPqrv4cNfuu2pxPil_LgQ-1; Thu, 12 Jan 2023 19:07:56 -0500 X-MC-Unique: ZHPqrv4cNfuu2pxPil_LgQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3BBA6811E6E; Fri, 13 Jan 2023 00:07:56 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-4.brq.redhat.com [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDE512166B26; Fri, 13 Jan 2023 00:07:55 +0000 (UTC) Date: Fri, 13 Jan 2023 01:07:52 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v4 0/8] Don't use additional sockets for receiving "spliced" UDP communications Message-ID: <20230113010752.632b351a@elisabeth> In-Reply-To: <20230105225003.023e4e66@elisabeth> References: <20230105042625.1981812-1-david@gibson.dropbear.id.au> <20230105225003.023e4e66@elisabeth> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: XCKWHWYBI6Q7W3ZD5IFVGCFCIBSUSGF6 X-Message-ID-Hash: XCKWHWYBI6Q7W3ZD5IFVGCFCIBSUSGF6 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 5 Jan 2023 22:50:03 +0100 Stefano Brivio wrote: > On Thu, 5 Jan 2023 15:26:17 +1100 > David Gibson wrote: > > > At present, the UDP "splice" and "tap" paths are quite separate. We > > have separate sockets to receive packets bound for the tap and splice > > paths. This leads to some code duplication, and extra open sockets. > > > > This series partially unifies the two paths, allowing us to use a > > single (host side) socket, bound to 0.0.0.0 or :: to receive packets > > for both cases. > > > > Changes since v3: > > * Fixed really dumb compile error, and actually ran through the tests. > > Oops. > > Changes since v2: > > * Don't receive multiple packets at once for pasta mode - seems to > > hurt throughput on balance. > > * Add some comments clarifying reasoning here. > > Changes since v1: > > * Renamed udp_localname[46] to udp[46]_localname > > * Allow handling of UDP port 0 > > * Fix a bug which could misidentify certain v6 packets as v4-spliceable > > * Some minor cosmetic fixes to code and commit messages > > Thanks, this looks good to me now, and I'm trying to run the tests > before applying it, but for some reason they get invariably stuck at > perf/passt_udp in the host to guest throughput test. > > I think it has nothing to do with this series, and it's rather related > to the "new" suspected virtio-net TX timeout issue we started hitting a > while ago, I still need to play with kernel version/workarounds etc. > I'll keep you posted. Finally, tests consistently pass with a workaround Laurent found, that is, reverting kernel commit a7766ef18b33 ("virtio_net: disable cb aggressively") from the kernel I'm using for guests. I just pushed this, I'm testing the other pending series now. -- Stefano