From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id C88FB5A005E for ; Tue, 24 Jan 2023 22:20:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674595254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hbNIo6aNo9DoROdaTWZ3hpmeJs67u828hhZHPQ0D3YU=; b=YqDpOWtoxAKKaKwODOgp8YjDZJqZ+v0iZtfoC98k2RJIDLxaxnHlExEoKg97b5QZF4nBF8 B4ozR4QSv5iHBiIheAiWPANkmGBMSQmBGwVIlkTVpQJNf4UHOQTIdlDAOWCP9S04As7lvn c4eDw3jagm+K/gU4YowaknutzUL/Qfs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-671-KryYEV21M5OEeW0lkxZVKw-1; Tue, 24 Jan 2023 16:20:53 -0500 X-MC-Unique: KryYEV21M5OEeW0lkxZVKw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3C7A1858F0E; Tue, 24 Jan 2023 21:20:52 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-4.brq.redhat.com [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7C5C492B00; Tue, 24 Jan 2023 21:20:51 +0000 (UTC) Date: Tue, 24 Jan 2023 22:20:43 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v3 00/18] RFC: Unify and simplify tap send path Message-ID: <20230124222043.281ef58c@elisabeth> In-Reply-To: <20230106004322.985665-1-david@gibson.dropbear.id.au> References: <20230106004322.985665-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 47LJEUXDIQAU5X2I6JEFVYWLRUOJDWOX X-Message-ID-Hash: 47LJEUXDIQAU5X2I6JEFVYWLRUOJDWOX X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 6 Jan 2023 11:43:04 +1100 David Gibson wrote: > Although we have an abstraction for the "slow path" (DHCP, NDP) guest > bound packets, the TCP and UDP forwarding paths write directly to the > tap fd. However, it turns out how they send frames to the tap device > is more similar than it originally appears. > > This series unifies the low-level tap send functions for TCP and UDP, > and makes some clean ups along the way. > > This is based on my earlier outstanding series. For some reason, performance tests consistently get stuck (both TCP and UDP, sometimes throughput, sometimes latency tests) with this series, and not without it, but I don't see any possible relationship with that. I checked debug output and I couldn't find anything obviously wrong there. I just started checking packet captures now... -- Stefano