From: Stefano Brivio <sbrivio@redhat.com>
To: Paul Holzinger <pholzing@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] pasta: do not leak netlink sock into child
Date: Wed, 8 Feb 2023 14:00:59 +0100 [thread overview]
Message-ID: <20230208140059.7962d8dd@elisabeth> (raw)
In-Reply-To: <20230207151046.76157-1-pholzing@redhat.com>
On Tue, 7 Feb 2023 16:10:46 +0100
Paul Holzinger <pholzing@redhat.com> wrote:
> When spawning a child command with pasta command... pasta should not
> leak fds that it opened. Only the fds that were already open should be
> given to the child.
>
> Run `pasta --config-net -- ls -l /proc/self/fd` from a terminal where
> only stdin/out/err are open. The fd 3 was opend by ls to read the
> /proc/self/fd dir. But fd 5 is the netlink socket that was opend in
> pasta. To prevent such a leak we will open the socket with SOCK_CLOEXEC.
>
> Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Thanks for the patch, and welcome to the git log!
I'll push this out in a bit (still sorting some unrelated test failures
first).
--
Stefano
next prev parent reply other threads:[~2023-02-08 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 15:10 [PATCH] pasta: do not leak netlink sock into child Paul Holzinger
2023-02-08 13:00 ` Stefano Brivio [this message]
2023-02-13 1:15 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208140059.7962d8dd@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).