From: Laine Stump <laine@redhat.com>
To: passt-dev@passt.top, laine@laine.org
Subject: [PATCH v2 0/9] error logging fixes
Date: Wed, 8 Feb 2023 12:48:29 -0500 [thread overview]
Message-ID: <20230208174838.1680517-1-laine@redhat.com> (raw)
There are two topics covered here:
1) If a logFile is set, passt's behavior has been to send all error
messages there, and *not* to stderr. This makes it difficult for
another program that is exec'ing passt (and setting it to log to a
file) to report useful error messages when passt fails. The first
patch makes a simple change to the logging functions that checks a
global bool that is set true after all initialization is completed.
2) All the rest of the patches eliminate use of the blanket usage()
function when a commandline error is encountered (and add in
specific/details error messages when previously usage() was all that
was logged).
Laine Stump (9):
log to stderr until process is daemonized, even if a logfile is set
add errexit() to log an error message and exit with a single call
eliminate most calls to usage() in conf()
make conf_ports() exit immediately after logging error
make conf_pasta_ns() exit immediately after logging error
make conf_ugid() exit immediately after logging error
make conf_netns_opt() exit immediately after logging error
log a detailed error (not usage()) when there are extra non-option
arguments
convert all remaining err() followed by exit() to errexit()
conf.c | 471 ++++++++++++++++++++--------------------------------
isolation.c | 78 ++++-----
log.c | 33 ++--
log.h | 2 +
netlink.c | 3 +-
passt.c | 18 +-
pasta.c | 21 +--
tap.c | 30 ++--
8 files changed, 258 insertions(+), 398 deletions(-)
--
2.39.1
next reply other threads:[~2023-02-08 17:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:48 Laine Stump [this message]
2023-02-08 17:48 ` [PATCH v2 1/9] log to stderr until process is daemonized, even if a logfile is set Laine Stump
2023-02-09 17:45 ` Stefano Brivio
2023-02-14 3:41 ` Laine Stump
2023-02-08 17:48 ` [PATCH v2 2/9] add errexit() to log an error message and exit with a single call Laine Stump
2023-02-09 17:45 ` Stefano Brivio
2023-02-13 3:22 ` David Gibson
2023-02-13 10:46 ` Stefano Brivio
2023-02-08 17:48 ` [PATCH v2 3/9] eliminate most calls to usage() in conf() Laine Stump
2023-02-09 17:45 ` Stefano Brivio
2023-02-08 17:48 ` [PATCH v2 4/9] make conf_ports() exit immediately after logging error Laine Stump
2023-02-09 17:45 ` Stefano Brivio
2023-02-08 17:48 ` [PATCH v2 5/9] make conf_pasta_ns() " Laine Stump
2023-02-09 17:45 ` Stefano Brivio
2023-02-08 17:48 ` [PATCH v2 6/9] make conf_ugid() " Laine Stump
2023-02-13 4:23 ` Laine Stump
2023-02-08 17:48 ` [PATCH v2 7/9] make conf_netns_opt() " Laine Stump
2023-02-08 17:48 ` [PATCH v2 8/9] log a detailed error (not usage()) when there are extra non-option arguments Laine Stump
2023-02-09 17:45 ` Stefano Brivio
2023-02-08 17:48 ` [PATCH v2 9/9] convert all remaining err() followed by exit() to errexit() Laine Stump
2023-02-09 17:45 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208174838.1680517-1-laine@redhat.com \
--to=laine@redhat.com \
--cc=laine@laine.org \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).