From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id B59D25A026C for ; Wed, 8 Feb 2023 18:48:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675878523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IRToApfma8sTID1pTSk2kWjPUZmi9aDKgyKiI14Ncok=; b=dGHxget2gbS/d124yR4TZbmg0dAW9PapsBNtNDzlHgfbM9qgDLsS1Veawevd4s3BTEvLL/ eboOrSZYwBhGeec2e13/jHU4PDsHnF2EvvrpBVD9vowAtlf383pFsoKJGHVEKDDPyRr78A xJsupm+IeoKP+QJSMope+TVk4Vo9Utc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-88-lddPI7FFNmiV9lTaNivEiQ-1; Wed, 08 Feb 2023 12:48:40 -0500 X-MC-Unique: lddPI7FFNmiV9lTaNivEiQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 56FC729ABA0B; Wed, 8 Feb 2023 17:48:40 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.2.17.81]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C5F02166B29; Wed, 8 Feb 2023 17:48:40 +0000 (UTC) From: Laine Stump To: passt-dev@passt.top, laine@laine.org Subject: [PATCH v2 8/9] log a detailed error (not usage()) when there are extra non-option arguments Date: Wed, 8 Feb 2023 12:48:37 -0500 Message-Id: <20230208174838.1680517-9-laine@redhat.com> In-Reply-To: <20230208174838.1680517-1-laine@redhat.com> References: <20230208174838.1680517-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true Message-ID-Hash: TLOQHQ3T3VWRZLUTHC7B63VHRXRNFY65 X-Message-ID-Hash: TLOQHQ3T3VWRZLUTHC7B63VHRXRNFY65 X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Telling the user "this bit is wrong" is more useful than telling them "these are all the potential things that would be right; actual error identification is left as an exercise for the reader". Signed-off-by: Laine Stump --- conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf.c b/conf.c index 1bfbc55..ce4e3e5 100644 --- a/conf.c +++ b/conf.c @@ -1539,7 +1539,7 @@ void conf(struct ctx *c, int argc, char **argv) if (c->mode == MODE_PASTA) conf_pasta_ns(&netns_only, userns, netns, optind, argc, argv); else if (optind != argc) - usage(argv[0]); + errexit("Extra non-option argument: %s", argv[optind]); isolate_user(uid, gid, !netns_only, userns, c->mode); -- 2.39.1