From: Stefano Brivio <sbrivio@redhat.com>
To: Paul Holzinger <pholzing@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 1/2] pasta: correctly exit when execvp() fails
Date: Wed, 8 Feb 2023 19:14:21 +0100 [thread overview]
Message-ID: <20230208191421.38edb188@elisabeth> (raw)
In-Reply-To: <20230208155441.64306-1-pholzing@redhat.com>
On Wed, 8 Feb 2023 16:54:40 +0100
Paul Holzinger <pholzing@redhat.com> wrote:
> By default clone() will create a child that does not send SIGCHLD when
> the child exits. The caller has to specifiy the SIGNAL it should get in
> the flag bitmask.
> see clone(2) under "The child termination signal"
>
> This fixes the problem where pasta would not exit when the execvp()
> call failed, i.e. when the command does not exists.
>
> Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Thanks, this looks good to me, pushing later.
--
Stefano
next prev parent reply other threads:[~2023-02-08 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 15:54 [PATCH 1/2] pasta: correctly exit when execvp() fails Paul Holzinger
2023-02-08 15:54 ` [PATCH 2/2] pasta: propagate exit code from child command Paul Holzinger
2023-02-08 18:14 ` Stefano Brivio
2023-02-09 14:23 ` Paul Holzinger
2023-02-08 18:14 ` Stefano Brivio [this message]
2023-02-13 1:15 ` [PATCH 1/2] pasta: correctly exit when execvp() fails Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208191421.38edb188@elisabeth \
--to=sbrivio@redhat.com \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).