From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 0816D5A0082 for ; Wed, 8 Feb 2023 19:14:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675880066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bB1l3RwJxIfIQwZQtM4w1mMdXiwUvdeJluYxu+PE5jM=; b=JFTZ8WTL4o7YG7bOUyM1YfulqmmiKGN0iUlBywEpXz87NZeRygD1eywWf56FMe4d1wu0ty uy4mDNOglJuEGRcMFrqgYT+bgETuBLqwLWblzavU11IpUa1amCC7c/QJxZ98Y1agQ64vfA Ou7eQvxP8pP2bDQbA76ku/FP7+P8jiY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-212-ajwVEGPvM5ydI7Fa0ir5BA-1; Wed, 08 Feb 2023 13:14:24 -0500 X-MC-Unique: ajwVEGPvM5ydI7Fa0ir5BA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 752333810B13 for ; Wed, 8 Feb 2023 18:14:24 +0000 (UTC) Received: from maya.cloud.tilaa.com (ovpn-208-4.brq.redhat.com [10.40.208.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EF40492C3F; Wed, 8 Feb 2023 18:14:24 +0000 (UTC) Date: Wed, 8 Feb 2023 19:14:21 +0100 From: Stefano Brivio To: Paul Holzinger Subject: Re: [PATCH 1/2] pasta: correctly exit when execvp() fails Message-ID: <20230208191421.38edb188@elisabeth> In-Reply-To: <20230208155441.64306-1-pholzing@redhat.com> References: <20230208155441.64306-1-pholzing@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: XDZJKUG5I3PAUH7Z3ZQGQUW6FJHFNQAP X-Message-ID-Hash: XDZJKUG5I3PAUH7Z3ZQGQUW6FJHFNQAP X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 8 Feb 2023 16:54:40 +0100 Paul Holzinger wrote: > By default clone() will create a child that does not send SIGCHLD when > the child exits. The caller has to specifiy the SIGNAL it should get in > the flag bitmask. > see clone(2) under "The child termination signal" > > This fixes the problem where pasta would not exit when the execvp() > call failed, i.e. when the command does not exists. > > Signed-off-by: Paul Holzinger Thanks, this looks good to me, pushing later. -- Stefano