public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Paul Holzinger <pholzing@redhat.com>
Subject: [PATCH] test/pasta_options: Ignore failures on shell 'exit'
Date: Mon, 13 Feb 2023 02:12:12 +0100	[thread overview]
Message-ID: <20230213011212.1198757-1-sbrivio@redhat.com> (raw)

On shell 'exit' commands, running shells from pasta, we might get:

  Cannot set tty process group (No such process)

as some TTY devices might be unaccessible. This is harmless, but
after commit "pasta: propagate exit code from child command", we'll
get test failures there, at least with dash.

Ignore those explicitly with a ugly workaround: we can't simply do
something like:

	exit || :

because the failure is reported by the shell itself once it exits,
regardless of the command evaluation.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
This is already applied, I needed to unblock tests. Posting anyway
for reviews.

 test/pasta_options/log_to_file | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/test/pasta_options/log_to_file b/test/pasta_options/log_to_file
index 587bf8e..29fb2c8 100644
--- a/test/pasta_options/log_to_file
+++ b/test/pasta_options/log_to_file
@@ -34,12 +34,14 @@ set	PORTS -t 10001,10002 -u 10001,10002
 set	LOG_FILE __STATEDIR__/pasta.log
 
 passt	./pasta -l __LOG_FILE__
-passt	exit
+passtb	exit
+sleep	1
 check	[ -s __LOG_FILE__ ]
 
 test	Log truncated on creation
 passt	./pasta -l __LOG_FILE__
-passt	exit
+passtb	exit
+sleep	1
 check	[ $(cat __LOG_FILE__ | wc -l) -eq 1 ]
 
 test	Maximum log size
@@ -85,6 +87,7 @@ check_log_size_mountns
 test	Timestamp consistency after rotations (no FALLOC_FL_COLLAPSE_RANGE)
 check	tail -n +2 __LOG_FILE__ | cut -f1 -d' ' | tr -d [.:] | sort -c
 
-passt	exit
+passtb	exit
+sleep	1
 passt	umount __STATEDIR__/t
 passt	exit
-- 
@@ -34,12 +34,14 @@ set	PORTS -t 10001,10002 -u 10001,10002
 set	LOG_FILE __STATEDIR__/pasta.log
 
 passt	./pasta -l __LOG_FILE__
-passt	exit
+passtb	exit
+sleep	1
 check	[ -s __LOG_FILE__ ]
 
 test	Log truncated on creation
 passt	./pasta -l __LOG_FILE__
-passt	exit
+passtb	exit
+sleep	1
 check	[ $(cat __LOG_FILE__ | wc -l) -eq 1 ]
 
 test	Maximum log size
@@ -85,6 +87,7 @@ check_log_size_mountns
 test	Timestamp consistency after rotations (no FALLOC_FL_COLLAPSE_RANGE)
 check	tail -n +2 __LOG_FILE__ | cut -f1 -d' ' | tr -d [.:] | sort -c
 
-passt	exit
+passtb	exit
+sleep	1
 passt	umount __STATEDIR__/t
 passt	exit
-- 
2.35.1


             reply	other threads:[~2023-02-13  1:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  1:12 Stefano Brivio [this message]
2023-02-13  2:30 ` [PATCH] test/pasta_options: Ignore failures on shell 'exit' David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213011212.1198757-1-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).