Re: [PATCH] Make assertions actually useful

[Stefano Brivio <sbrivio@redhat.com>]

On Mon, 16 Jan 2023 14:15:27 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> There are some places in passt/pasta which #include <assert.h> and make
> various assertions.  If we hit these something has already gone wrong, but
> they're there so that we a useful message instead of cryptic misbehaviour
> if assumptions we thought were correct turn out not to be.
> 
> Except.. the glibc implementation of assert() uses syscalls that aren't in
> our seccomp filter, so we'll get a SIGSYS before it actually prints the
> message.  Work around this by adding our own ASSERT() implementation using
> our existing err() function to log the message, and an abort().  The
> abort() probably also won't work exactly right with seccomp, but once we've
> printed the message, dying with a SIGSYS works just as well as dying with
> a SIGABRT.
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Applied.

-- 
Stefano