From: Laine Stump <laine@redhat.com>
To: passt-dev@passt.top
Subject: [PATCH v4 8/9] log a detailed error (not usage()) when there are extra non-option arguments
Date: Wed, 15 Feb 2023 03:24:36 -0500 [thread overview]
Message-ID: <20230215082437.110151-9-laine@redhat.com> (raw)
In-Reply-To: <20230215082437.110151-1-laine@redhat.com>
Signed-off-by: Laine Stump <laine@redhat.com>
---
conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conf.c b/conf.c
index d020b4f..f175405 100644
--- a/conf.c
+++ b/conf.c
@@ -1536,7 +1536,7 @@ void conf(struct ctx *c, int argc, char **argv)
if (c->mode == MODE_PASTA)
conf_pasta_ns(&netns_only, userns, netns, optind, argc, argv);
else if (optind != argc)
- usage(argv[0]);
+ die("Extra non-option argument: %s", argv[optind]);
isolate_user(uid, gid, !netns_only, userns, c->mode);
--
@@ -1536,7 +1536,7 @@ void conf(struct ctx *c, int argc, char **argv)
if (c->mode == MODE_PASTA)
conf_pasta_ns(&netns_only, userns, netns, optind, argc, argv);
else if (optind != argc)
- usage(argv[0]);
+ die("Extra non-option argument: %s", argv[optind]);
isolate_user(uid, gid, !netns_only, userns, c->mode);
--
2.39.1
next prev parent reply other threads:[~2023-02-15 8:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 8:24 [PATCH v4 0/9] error logging fixes Laine Stump
2023-02-15 8:24 ` [PATCH v4 1/9] log to stderr until process is daemonized, even if a log file is set Laine Stump
2023-02-15 11:54 ` Stefano Brivio
2023-02-16 5:30 ` David Gibson
2023-02-16 17:50 ` Stefano Brivio
2023-02-15 8:24 ` [PATCH v4 2/9] add die() to log an error message and exit with a single call Laine Stump
2023-02-16 5:31 ` David Gibson
2023-02-15 8:24 ` [PATCH v4 3/9] eliminate most calls to usage() in conf() Laine Stump
2023-02-16 5:34 ` David Gibson
2023-02-15 8:24 ` [PATCH v4 4/9] make conf_ports() exit immediately after logging error Laine Stump
2023-02-16 5:36 ` David Gibson
2023-02-15 8:24 ` [PATCH v4 5/9] make conf_pasta_ns() " Laine Stump
2023-02-16 5:37 ` David Gibson
2023-02-15 8:24 ` [PATCH v4 6/9] make conf_ugid() " Laine Stump
2023-02-16 5:38 ` David Gibson
2023-02-15 8:24 ` [PATCH v4 7/9] make conf_netns_opt() " Laine Stump
2023-02-16 5:38 ` David Gibson
2023-02-15 8:24 ` Laine Stump [this message]
2023-02-16 5:39 ` [PATCH v4 8/9] log a detailed error (not usage()) when there are extra non-option arguments David Gibson
2023-02-15 8:24 ` [PATCH v4 9/9] convert all remaining err() followed by exit() to die() Laine Stump
2023-02-16 5:40 ` David Gibson
2023-02-15 11:56 ` [PATCH v4 0/9] error logging fixes Stefano Brivio
2023-02-16 22:21 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215082437.110151-9-laine@redhat.com \
--to=laine@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).