From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id C24225A0271 for ; Thu, 16 Feb 2023 06:43:22 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4PHP4L05XFz4x8H; Thu, 16 Feb 2023 16:43:13 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1676526194; bh=Zu78NVg+6NpM8g3hUchgCcTiXmZ87VePcqH/CQ5qK28=; h=From:To:Cc:Subject:Date:From; b=ht22YEIZ5jvCGFSRjSGxw3dgUyEXLwGTM98J66bbVkooA1vJhpZbCBsbAqRays1xs 4Ls+/svNnpAroEixmiO0uorRpN7TqSAVRzFi0mmYfXJ9MO27KfRu+sDkZ5zhnhNqFL 5ykqHONaX5MZfLg7/xoPuR2oCizYHqmojFZG/m0I= From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 0/4] Some cleanups to tap and tcp Date: Thu, 16 Feb 2023 16:43:07 +1100 Message-Id: <20230216054311.2131853-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.39.1 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: EUP4CANJPKASOSDZAUZAL27HVIRY4XIZ X-Message-ID-Hash: EUP4CANJPKASOSDZAUZAL27HVIRY4XIZ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This is a handful of simple cleanups which I made while investigating https://bugs.passt.top/show_bug.cgi?id=41. Note that these don't themselves actually address that bug, they're just unrelated cleanups that happen to be in adjacent code. I've run basic tests on these, but not quite the complete test suite: I haven't yet had a chance to debug an unrelated problem with the IPv4 performance tests failing. Changes since v1: * Minor comment and style fixes David Gibson (4): tap: Don't pcap frames that didn't get sent tap: Eliminate goto from tap_handler() tcp: Remove 'recvmsg' goto from tcp_data_from_sock tcp: Remove 'zero_len' goto from tcp_data_from_sock tap.c | 49 +++++++++++++++++++++++++++---------------------- tcp.c | 37 +++++++++++++++++-------------------- 2 files changed, 44 insertions(+), 42 deletions(-) -- 2.39.1