From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 98D7E5A0082 for ; Thu, 16 Feb 2023 08:19:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676531985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1nWeo/4OrjKMnUGP1jU45STqZ8CwuqxIkMi913iKUp8=; b=OWvDRow1QygzVGuPrfqKuKl2spagCOw14L7ZR8Qazi7ZVYtenlB3CzLWsSYxrqXRpK0yZv i3nEzf1FC5x6FF6St5vKn0FPg4MiRkTF1Ru2s6ZH5zbAzT+xXYSSvwRuS2J0NJ0adOsB6E /9Hq8A3EkcehHnwrCD6E5W9VlLMzdYI= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-326-FOD2jQTsMD-7HvCPrh8vBQ-1; Thu, 16 Feb 2023 02:19:41 -0500 X-MC-Unique: FOD2jQTsMD-7HvCPrh8vBQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64EEF3806705; Thu, 16 Feb 2023 07:19:41 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3D8B9492B0E; Thu, 16 Feb 2023 07:19:40 +0000 (UTC) Date: Thu, 16 Feb 2023 08:19:37 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH] passt.1: Fix typo, improve wording in examples of port forwarding specifiers Message-ID: <20230216081937.478f0b3d@elisabeth> In-Reply-To: References: <20230216010900.2224288-1-sbrivio@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QUY4AMYBT4NWZGFZXOGWUGTAQXVBUGWW X-Message-ID-Hash: QUY4AMYBT4NWZGFZXOGWUGTAQXVBUGWW X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laine Stump , Yalan Zhang X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 16 Feb 2023 13:44:20 +1100 David Gibson wrote: > On Thu, Feb 16, 2023 at 02:09:00AM +0100, Stefano Brivio wrote: > > Based on a patch from Laine, and reports from Laine and Yalan: fix > > the "22-80:32-90" example, and improve wording for the other ones: > > instead of using "to" to denote the end of a range, use "between ... > > and", so that it's clear we're *not* referring to target ports. > > > > Reported-by: Laine Stump > > Reported-by: Yalan Zhang > > Fixes: da20f57f19dc ("passt, qrap: Add man pages") > > Signed-off-by: Stefano Brivio > > Reviewed-by: David Gibson > > Although, a few additional refinements suggested below: > > > --- > > passt.1 | 29 ++++++++++++++++------------- > > 1 file changed, 16 insertions(+), 13 deletions(-) > > > > diff --git a/passt.1 b/passt.1 > > index 528763b..ec09c22 100644 > > --- a/passt.1 > > +++ b/passt.1 > > @@ -338,7 +338,7 @@ Examples: > > .RS > > .TP > > -t 22 > > -Forward local port 22 to 22 on the guest > > +Forward local port 22 to port 22 on the guest > > .TP > > -t 22:23 > > Forward local port 22 to port 23 on the guest > > @@ -347,10 +347,11 @@ Forward local port 22 to port 23 on the guest > > Forward local ports 22 and 25 to ports 22 and 25 on the guest > > .TP > > -t 22-80 > > -Forward local ports 22 to 80 to corresponding ports on the guest > > +Forward local ports between 22 and 80 to corresponding ports on the guest > > .TP > > --t 22-80-32:90 > > -Forward local ports 22 to 80 to corresponding ports on the guest plus 10 > > +-t 22-80:32-90 > > +Forward local ports between 22 and 80 to corresponding ports on the guest, plus > > +10 > > I find it a bit hard to parse how the "plus 10" attaches to the rest > of the sentence. I'd suggest: > > Forward local ports between 22 and 80 to ports between 32 and > 90 on the guest. > > From a pedantic point of view that's less precise, but I think the > meaning of it going to be clearer in practice to most readers Ah, yes, thanks, much better. Same for all the other suggestions. Posting v2. -- Stefano