From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 5F6F55A026A for ; Thu, 16 Feb 2023 17:07:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676563631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qVxVfHh1j+oeWcJRXetykkF3l/sfpdOh6sgf/HG6rFQ=; b=XXPza5ThdJwsiRYsIQhGndHBIFM3m7PW5fO2+rl72UKT0QrTuOSIDhB5WZJtwk4vvsjoSA Ah5JzUpIKr6RCV4OICVYh5cuOOuE5NxuYB5qNHzUrdDHEesyzSPi69w0q9/nEskU7m8chT /cqyn4nCoH9fv3t+Yi09x/sAWp+JBFo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-74-mjs3FPjFMgKQiLenOBVXgg-1; Thu, 16 Feb 2023 11:07:05 -0500 X-MC-Unique: mjs3FPjFMgKQiLenOBVXgg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDD4418A647E for ; Thu, 16 Feb 2023 16:06:53 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A55EA2026D4B; Thu, 16 Feb 2023 16:06:53 +0000 (UTC) Date: Thu, 16 Feb 2023 17:06:50 +0100 From: Stefano Brivio To: Michal Privoznik Subject: Re: [PATCH v2 1/5] qemu_passt: Avoid double daemonizing passt Message-ID: <20230216170650.4da5ed13@elisabeth> In-Reply-To: <4fa71e685d69f496d481ef51157c1ffa4c85166d.1676554196.git.mprivozn@redhat.com> References: <4fa71e685d69f496d481ef51157c1ffa4c85166d.1676554196.git.mprivozn@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7DOJOIV2DQN2IJKF2RJH73GJZJS7GXXZ X-Message-ID-Hash: 7DOJOIV2DQN2IJKF2RJH73GJZJS7GXXZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: libvir-list@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 16 Feb 2023 14:32:48 +0100 Michal Privoznik wrote: > When passt is started, it daemonizes itself by default. There's > no point in having our virCommand module daemonize it too. > > Signed-off-by: Michal Privoznik > --- > src/qemu/qemu_passt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c > index 78830fdc26..adc69fc052 100644 > --- a/src/qemu/qemu_passt.c > +++ b/src/qemu/qemu_passt.c > @@ -156,7 +156,6 @@ qemuPasstStart(virDomainObj *vm, > virCommandClearCaps(cmd); > virCommandSetPidFile(cmd, pidfile); > virCommandSetErrorFD(cmd, &errfd); > - virCommandDaemonize(cmd); > > virCommandAddArgList(cmd, > "--one-off", For what it's worth, Reviewed-by: Stefano Brivio -- Stefano