From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id BC8125A0082 for ; Thu, 16 Feb 2023 17:07:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676563624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RHvLMRSrwBVSZYVGWrdhBPQrsL4F56nfTM+xZaZ8VSM=; b=HAwrdfIQVeRCHnjHsuyh49khFXK+OCp+XMIP6bK3uYRgaIB2mhlLesu08XsGdNtZL6H1P4 HeOl1BuMqcZ7ajFnNZnkfFhBKNbuG56u6K1cLnlO9GFnL2ThQKp8TTYyKIdbtoX8VlnnWH G0VGUmfIl88v/hAQBK9tFSDtNb7mog8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-38-TzPUKblIPiin-H5Lz9bilA-1; Thu, 16 Feb 2023 11:07:01 -0500 X-MC-Unique: TzPUKblIPiin-H5Lz9bilA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7CA5D18A6483 for ; Thu, 16 Feb 2023 16:06:57 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55B082166B31; Thu, 16 Feb 2023 16:06:57 +0000 (UTC) Date: Thu, 16 Feb 2023 17:06:55 +0100 From: Stefano Brivio To: Michal Privoznik Subject: Re: [PATCH v2 2/5] qemu_passt: Report passt's error on failed start Message-ID: <20230216170655.4141c21f@elisabeth> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: RR5OC4U2MLJGP4EGMQA7NBXZARA37Q6E X-Message-ID-Hash: RR5OC4U2MLJGP4EGMQA7NBXZARA37Q6E X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: libvir-list@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 16 Feb 2023 14:32:49 +0100 Michal Privoznik wrote: > When starting passt, it may write something onto its stderr > (convincing it to print even more is addressed later). Pass this > string we read to user. > > Since we're not daemonizing passt anymore (see previous commit), > we can let virCommand module do all the heavy lifting and switch > to virCommandSetErrorBuffer() instead of reading error from an > FD. > > Signed-off-by: Michal Privoznik Reviewed-by: Stefano Brivio -- Stefano