Re: [PATCH v4 1/9] log to stderr until process is daemonized, even if a log file is set

[Stefano Brivio <sbrivio@redhat.com>]

On Thu, 16 Feb 2023 16:30:53 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Wed, Feb 15, 2023 at 03:24:29AM -0500, Laine Stump wrote:
> > Once a log file (specified on the commandline) is opened, the logging
> > functions will stop sending error logs to stderr, which is annoying if
> > passt has been started by another process that wants to collect error
> > messages from stderr so it can report why passt failed to start. It
> > would be much nicer if passt continued sending all log messages to
> > stderr until it daemonizes itself (at which point the process that
> > started passt can assume that it was started successfully).
> > 
> > The system log mask is set to LOG_EMERG when the process starts, and
> > we're already using that to do "special" logging during the period
> > from process start until the log level requested on the commandline is
> > processed (setting the log mask to something else). This period
> > *almost* matches with "the time before the process is daemonized"; if
> > we just delay setting the log mask a tiny bit, then it will match
> > exactly, and we can use it to determine if we need to send log
> > messages to stderr even when a log file has been specified and opened.
> > 
> > This patch delays the setting of the log mask until immediately before
> > the call to __daemon(). It also modifies logfn() slightly, so that it
> > will log to stderr any time log mask is LOG_EMERG, even if a log file
> > has been opened.
> > 
> > Signed-off-by: Laine Stump <laine@redhat.com>  
> 
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

Sorry David, I missed to add *all* your Reviewed-by tags on this
series. :/ Thanks a lot for reviewing all this.

-- 
Stefano