From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 2A5495A005E for ; Fri, 17 Feb 2023 08:44:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676619885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4skLF1CwNV8b6OkCGB/tc9sb2fakcspE8m/eGK8UXpo=; b=ZHK9sk6pZuIDcOcX5aujPME/ONEyCWcr/jtRQb0budink685qFd8sTX9CfyiHdsp0scnS1 2vCCoYbvO34yqCSKPAXZswhjsbAdRxN+h1uOtJJDByiQ4HqjwXHV7Pozblm6rGUdjhK1VO uiOmdEaz5nclyduBm2lP+22ngmW4zZE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-127-lTgF1epEOMmguKloyp2BoQ-1; Fri, 17 Feb 2023 02:44:43 -0500 X-MC-Unique: lTgF1epEOMmguKloyp2BoQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 87A642817238; Fri, 17 Feb 2023 07:44:43 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65BE7492C14; Fri, 17 Feb 2023 07:44:43 +0000 (UTC) Date: Fri, 17 Feb 2023 08:44:34 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/4] Some cleanups to tap and tcp Message-ID: <20230217084434.6fe7f741@elisabeth> In-Reply-To: References: <20230216054311.2131853-1-david@gibson.dropbear.id.au> <20230216232207.198224bb@elisabeth> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: DQK3AFGVKGR724FZHP3GQTOEEYFPTV3A X-Message-ID-Hash: DQK3AFGVKGR724FZHP3GQTOEEYFPTV3A X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 17 Feb 2023 09:55:59 +1100 David Gibson wrote: > On Thu, Feb 16, 2023 at 11:22:07PM +0100, Stefano Brivio wrote: > > On Thu, 16 Feb 2023 16:43:07 +1100 > > David Gibson wrote: > > > > > This is a handful of simple cleanups which I made while investigating > > > https://bugs.passt.top/show_bug.cgi?id=41. Note that these don't > > > themselves actually address that bug, they're just unrelated cleanups > > > that happen to be in adjacent code. > > > > > > I've run basic tests on these, but not quite the complete test suite: > > > I haven't yet had a chance to debug an unrelated problem with the IPv4 > > > performance tests failing. > > > > > > Changes since v1: > > > * Minor comment and style fixes > > > > > > David Gibson (4): > > > tap: Don't pcap frames that didn't get sent > > > tap: Eliminate goto from tap_handler() > > > tcp: Remove 'recvmsg' goto from tcp_data_from_sock > > > tcp: Remove 'zero_len' goto from tcp_data_from_sock > > > > Applied. > > Hmm.. I'm not seeing them in the tree yet.. Oops, yes, I actually pushed it a few minutes after you sent this email... -- Stefano