public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Andrea Bolognani <abologna@redhat.com>
Cc: passt-dev@passt.top, Alona Paz <alkaplan@redhat.com>
Subject: Re: [PATCH] qrap: Pass PCI device numbers to qemu in base 10, not in base 16
Date: Wed, 22 Feb 2023 14:02:20 +0100	[thread overview]
Message-ID: <20230222140220.43db3a68@elisabeth> (raw)
In-Reply-To: <CABJz62MYK4POhRaLGZgZqnp_4e6ZkOoWL26X373YVk4yXgjj0A@mail.gmail.com>

On Wed, 22 Feb 2023 04:47:32 -0800
Andrea Bolognani <abologna@redhat.com> wrote:

> On Wed, Feb 22, 2023 at 11:45:08AM +0100, Stefano Brivio wrote:
> > On Wed, 22 Feb 2023 02:40:32 -0800 Andrea Bolognani <abologna@redhat.com> wrote:  
> > > What I think needs to happen, is that each pci_dev should contain a
> > > base value (16 for i440fx and 10 for q35), which is used both in the
> > > strtol() call used to parse the command line produced by libvirt and
> > > to decide whether %x or %i should be used with snprintf() to generate
> > > qrap's own arguments.  
> >
> > Right, I think it makes sense. Will you prepare a patch in this sense
> > or should I try?  
> 
> Sure, I can give it a shot. It might take a bit, because the code is
> kinda tricky and there is no test suite (that I'm aware of?) for this
> part.

Thanks!

Right, sorry, no tests covering qrap at the moment, and the code is
horrible. The KubeVirt integration might help if you have an environment
ready.

-- 
Stefano


  reply	other threads:[~2023-02-22 13:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 19:24 [PATCH] qrap: Pass PCI device numbers to qemu in base 10, not in base 16 Stefano Brivio
2023-02-22  0:27 ` David Gibson
2023-02-22 10:40 ` Andrea Bolognani
2023-02-22 10:45   ` Stefano Brivio
2023-02-22 12:47     ` Andrea Bolognani
2023-02-22 13:02       ` Stefano Brivio [this message]
2023-02-22 22:27   ` David Gibson
2023-02-23 14:06     ` Andrea Bolognani
2023-02-24  7:14       ` Stefano Brivio
2023-02-24 19:05         ` Andrea Bolognani
2023-02-24 19:32           ` Stefano Brivio
2023-02-25  1:44             ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230222140220.43db3a68@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=abologna@redhat.com \
    --cc=alkaplan@redhat.com \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).