From: Andrea Bolognani <abologna@redhat.com>
To: passt-dev@passt.top
Subject: [PATCH 2/5] qrap: Fix support for pc machines
Date: Fri, 24 Feb 2023 19:49:46 +0100 [thread overview]
Message-ID: <20230224184949.518615-3-abologna@redhat.com> (raw)
In-Reply-To: <20230224184949.518615-1-abologna@redhat.com>
The JSON version of the template is incorrect, making qrap
completely unusable when JSON arguments are used together
with the pc machine type.
Fixes: b944ca185587 ("qrap: Support JSON syntax for -device")
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
qrap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qrap.c b/qrap.c
index 2443fa3..5c18cec 100644
--- a/qrap.c
+++ b/qrap.c
@@ -94,7 +94,7 @@ static const struct pci_dev {
{
"pc-", "virtio-net-pci",
"bus=pci.0,addr=0x", "",
- "\"bus\":\"pci.0\",\"addr=0x", "",
+ "\"bus\":\"pci.0\",\"addr\":\"0x", "",
2, /* 1: ISA bridge */ 31
},
{
--
@@ -94,7 +94,7 @@ static const struct pci_dev {
{
"pc-", "virtio-net-pci",
"bus=pci.0,addr=0x", "",
- "\"bus\":\"pci.0\",\"addr=0x", "",
+ "\"bus\":\"pci.0\",\"addr\":\"0x", "",
2, /* 1: ISA bridge */ 31
},
{
--
2.39.2
next prev parent reply other threads:[~2023-02-24 18:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 18:49 [PATCH 0/5] qrap: Fix a number of issues Andrea Bolognani
2023-02-24 18:49 ` [PATCH 1/5] qrap: Fix limits for PCI addresses Andrea Bolognani
2023-02-26 23:54 ` David Gibson
2023-02-24 18:49 ` Andrea Bolognani [this message]
2023-02-26 23:55 ` [PATCH 2/5] qrap: Fix support for pc machines David Gibson
2023-02-24 18:49 ` [PATCH 3/5] qrap: Drop args in JSON format Andrea Bolognani
2023-02-26 23:56 ` David Gibson
2023-02-24 18:49 ` [PATCH 4/5] qrap: Introduce machine-specific PCI address base Andrea Bolognani
2023-02-26 23:58 ` David Gibson
2023-02-24 18:49 ` [PATCH 5/5] qrap: Generate -netdev as JSON Andrea Bolognani
2023-02-27 0:00 ` David Gibson
2023-02-24 19:36 ` [PATCH 0/5] qrap: Fix a number of issues Andrea Bolognani
2023-02-27 10:25 ` Stefano Brivio
2023-02-27 13:59 ` Andrea Bolognani
2023-02-27 21:54 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224184949.518615-3-abologna@redhat.com \
--to=abologna@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).