From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 7B15E5A0268 for ; Mon, 27 Feb 2023 11:25:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677493531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1QpLWLTO6/QZg+zZqXKIfu9lCqk7ebZ6fioY8FLQxhk=; b=UeDsku/kuPlfqpUdpmFR/V5a2UdNkh79xfAat5kmY0cLpYJGj06szkk1lNrkWDNAIhuJ8o YkUjDAhFJ960b8p2MiV3+8hRok4jqC+wunTOUSvSsUhNe9CE5vtcJhd8I4wWfm1Flx9kWk q9vFOI0nmWjnjUj+px6XnLHbqyDoqDI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-29-E5LRUkMIPMatddpWBi69cw-1; Mon, 27 Feb 2023 05:25:30 -0500 X-MC-Unique: E5LRUkMIPMatddpWBi69cw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D342685D185 for ; Mon, 27 Feb 2023 10:25:29 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AB1EB1121314; Mon, 27 Feb 2023 10:25:29 +0000 (UTC) Date: Mon, 27 Feb 2023 11:25:27 +0100 From: Stefano Brivio To: Andrea Bolognani Subject: Re: [PATCH 0/5] qrap: Fix a number of issues Message-ID: <20230227112527.01af34d3@elisabeth> In-Reply-To: References: <20230224184949.518615-1-abologna@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 4NYMA7B2GMOXZMGDV7YFCKARCZGFLV5W X-Message-ID-Hash: 4NYMA7B2GMOXZMGDV7YFCKARCZGFLV5W X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 24 Feb 2023 11:36:51 -0800 Andrea Bolognani wrote: > On Fri, Feb 24, 2023 at 07:49:44PM +0100, Andrea Bolognani wrote: > > Andrea Bolognani (5): > > qrap: Fix limits for PCI addresses > > qrap: Fix support for pc machines > > qrap: Drop args in JSON format > > qrap: Introduce machine-specific PCI address base > > qrap: Generate -netdev as JSON > > > > qrap.c | 47 +++++++++++++++++++++++++++++++++++------------ > > 1 file changed, 35 insertions(+), 12 deletions(-) > > Some information about testing. > > In order to convince myself that the changes I was working on were > correct, I have created a few quick and dirty test scripts. You can > find them here: > > https://gitlab.com/abologna/passt/-/commits/qrap-tests > > The commit contains a few YAML files: > > vmi-small-q35-passt.yaml # q35 VM with few devices > vmi-small-pc-passt.yaml # pc VM with few devices > vmi-big-q35-passt.yaml # q35 VM with many devices > vmi-big-pc-passt.yaml # pc VM with many devices > > Each one of those, fed into KubeVirt, results in qrap being called > with a bunch of command line arguments. These are normally passed to > the actual QEMU binary, but in my case I've hacked qrap so that > they're simply printed out. If you think it's useful, by the way, feel free to submit those as a patch for something on the lines of "test/kubevirt/qrap-tests", with explicit licensing terms and something similar to your email as README. We wouldn't run them automatically, I'm not sure I would personally try them out, qrap should hopefully go away in a few months (even though KubeVirt YAMLs could still be helpful), and... I know it's effort, so I'm not really pushing for it, you know better. Thanks! -- Stefano