From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id B595C5A0268 for ; Mon, 27 Feb 2023 22:54:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677534853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M7L7b76j8nbgvAiVu57vwnXLR/6q/y87F9s4yeg4ykU=; b=dEZLGyJOJuTgE4EcanegFbdlyWVbFFF752iXz/bW9Zh5poU/fFXV/RHP1HbMgX8x7/qENe iP4hrF/C0ZV9hVkQ7Z25Cp2YkDLDuDJMU8Em1TRXSADbcmL39wDQiwKYPvDq9pSH5bMjFH ORvpBPwDq3yj/QReP3tWpgDsC+NqFX4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-e5RdooPuO8KUPp6HR-_DNA-1; Mon, 27 Feb 2023 16:54:12 -0500 X-MC-Unique: e5RdooPuO8KUPp6HR-_DNA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1CC03815F66 for ; Mon, 27 Feb 2023 21:54:10 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C9A6D1121314; Mon, 27 Feb 2023 21:54:10 +0000 (UTC) Date: Mon, 27 Feb 2023 22:54:08 +0100 From: Stefano Brivio To: Andrea Bolognani Subject: Re: [PATCH 0/5] qrap: Fix a number of issues Message-ID: <20230227225408.19eefeaf@elisabeth> In-Reply-To: <20230224184949.518615-1-abologna@redhat.com> References: <20230224184949.518615-1-abologna@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BGOS4DUXBANZ7I5D7WBAUA2BFMCMHQLV X-Message-ID-Hash: BGOS4DUXBANZ7I5D7WBAUA2BFMCMHQLV X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 24 Feb 2023 19:49:44 +0100 Andrea Bolognani wrote: > Andrea Bolognani (5): > qrap: Fix limits for PCI addresses > qrap: Fix support for pc machines > qrap: Drop args in JSON format > qrap: Introduce machine-specific PCI address base > qrap: Generate -netdev as JSON > > qrap.c | 47 +++++++++++++++++++++++++++++++++++------------ > 1 file changed, 35 insertions(+), 12 deletions(-) You really seem to... like qrap. Series applied, thanks. I agree with David about 5/5 by the way: why should we add one more case we need to check, with the JSON format for -netdev? But you're a qrap connoisseur at this point, so... I just hope you don't have to deal with that part ever again. :) -- Stefano