From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id E75DA5A0262 for ; Sat, 4 Mar 2023 10:54:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677923698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8+yx1lc87fK/1RC/xFeyBudljsKEUuPUBHEUc4/4370=; b=RZNGXGiheo27Wr+ZL1NFtGwxkk0moUwpBl3gdRkmn6FZ08SDJEFULrL4xXSifRIqDp1OLi E3/ALqeCHHfoU19y/iFqi/3cbPSVApFjn5tWFKBlaOgSdHVcRCPzPQ0ZwRmNHG0RUn7lxo qTT3o6Su3aI/SucdBmnnClDW5kLsTmA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-665-z_bRZXNyO-WzwCZa8nVHJw-1; Sat, 04 Mar 2023 04:54:52 -0500 X-MC-Unique: z_bRZXNyO-WzwCZa8nVHJw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4D16A811E6E; Sat, 4 Mar 2023 09:54:52 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2623D492C14; Sat, 4 Mar 2023 09:54:52 +0000 (UTC) Date: Sat, 4 Mar 2023 10:54:50 +0100 From: Stefano Brivio To: KuhnChris Subject: Re: [PATCH 2/3] sbrivio/manual buffer size due to musl being 1024 Message-ID: <20230304105450.46f42ec4@elisabeth> In-Reply-To: <20230303224931.11791-2-kuhnchris+github@kuhnchris.eu> References: <20230303224931.11791-1-kuhnchris+github@kuhnchris.eu> <20230303224931.11791-2-kuhnchris+github@kuhnchris.eu> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: H7ZT5HW5LVKZD4JTBDMHYR7VVNY7GWOW X-Message-ID-Hash: H7ZT5HW5LVKZD4JTBDMHYR7VVNY7GWOW X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 3 Mar 2023 22:49:30 +0000 KuhnChris wrote: > --- > netlink.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) This patch should also come with a commit message. You can write what I explained on the ticket, and explain (in plain English) that this patch comes from me. Or even just add: From: Stefano Brivio at the beginning of the commit message. The rest here looks good to me (of course, I wrote it :D). -- Stefano