From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by passt.top (Postfix, from userid 1000) id 4FACA5A026F; Tue, 7 Mar 2023 00:28:39 +0100 (CET) From: Stefano Brivio To: passt-dev@passt.top Subject: [PATCH 3/4] contrib/selinux: Allow binding and connecting to all UDP and TCP ports Date: Tue, 7 Mar 2023 00:28:38 +0100 Message-Id: <20230306232839.1996920-4-sbrivio@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230306232839.1996920-1-sbrivio@redhat.com> References: <20230306232839.1996920-1-sbrivio@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: SMF6KL74WFVY6BNBA2RWY5U43WBFL3L4 X-Message-ID-Hash: SMF6KL74WFVY6BNBA2RWY5U43WBFL3L4 X-MailFrom: sbrivio@passt.top X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laine Stump , Andrea Bolognani X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Laine reports that with a simple: in libvirt's domain XML, passt won't start as it fails to bind arbitrary ports. That was actually the intention behind passt_port_t: the user or system administrator should have explicitly configured allowed ports on a given machine. But it's probably not realistic, so just allow any port to be bound and forwarded. Also fix up some missing operations on sockets. Reported-by: Laine Stump Signed-off-by: Stefano Brivio --- contrib/selinux/passt.te | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/contrib/selinux/passt.te b/contrib/selinux/passt.te index 6cd61f1..438155d 100644 --- a/contrib/selinux/passt.te +++ b/contrib/selinux/passt.te @@ -62,9 +62,6 @@ logging_log_file(passt_log_t); type passt_etc_t; files_config_file(passt_etc_t); -type passt_port_t; -typeattribute passt_port_t port_type; - role unconfined_r types passt_t; allow passt_t passt_exec_t : file { ioctl read getattr lock execute execute_no_trans entrypoint open } ; @@ -100,16 +97,22 @@ allow passt_t net_conf_t:lnk_file read; allow passt_t tmp_t:sock_file { create unlink write }; allow passt_t self:netlink_route_socket { bind create nlmsg_read read write setopt }; -allow passt_t self:tcp_socket create_stream_socket_perms; -corenet_tcp_sendrecv_generic_node(passt_t) -corenet_tcp_bind_generic_node(passt_t) -allow passt_t passt_port_t:tcp_socket { name_bind name_connect }; -allow passt_t http_port_t:tcp_socket { name_bind name_connect }; -allow passt_t self:udp_socket create_stream_socket_perms; -corenet_udp_sendrecv_generic_node(passt_t) -corenet_udp_bind_generic_node(passt_t) -allow passt_t passt_port_t:udp_socket { name_bind }; +corenet_tcp_bind_all_nodes(passt_t) +corenet_udp_bind_all_nodes(passt_t) + +corenet_tcp_bind_all_ports(passt_t) +corenet_udp_bind_all_ports(passt_t) + +corenet_tcp_connect_all_ports(passt_t) + +corenet_tcp_sendrecv_all_ports(passt_t) +corenet_udp_sendrecv_all_ports(passt_t) + allow passt_t node_t:icmp_socket { name_bind node_bind }; +allow passt_t port_t:icmp_socket name_bind; + +allow passt_t self:tcp_socket { create getopt setopt connect bind listen accept shutdown read write }; +allow passt_t self:udp_socket { create getopt setopt connect bind read write }; allow passt_t self:icmp_socket { bind create setopt read write }; allow passt_t user_tmp_t:dir { add_name write }; -- 2.39.2