From: Laine Stump <laine@redhat.com>
To: libvir-list@redhat.com
Cc: passt-dev@passt.top
Subject: [libvirt PATCH 4/4] qemu: set SELinux label of passt process to its own binary's label
Date: Wed, 8 Mar 2023 23:49:08 -0500 [thread overview]
Message-ID: <20230309044908.29316-5-laine@redhat.com> (raw)
In-Reply-To: <20230309044908.29316-1-laine@redhat.com>
set useBinarySpecificLabel = true when calling qemuSecurityCommandRun
for the passt process, so that the new process context will include
the binary-specific label that should be used for passt (passt_t)
rather than svirt_t (as would happen if useBinarySpecificLabel was
false). (The MCS part of the label, which is common to all child
processes related to a particular qemu domain instance, is also set).
Resolves: https://bugzilla.redhat.com/2172267
Signed-off-by: Laine Stump <laine@redhat.com>
---
src/qemu/qemu_passt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c
index fd0076077e..2153c0ac46 100644
--- a/src/qemu/qemu_passt.c
+++ b/src/qemu/qemu_passt.c
@@ -281,7 +281,7 @@ qemuPasstStart(virDomainObj *vm,
if (qemuExtDeviceLogCommand(driver, vm, cmd, "passt") < 0)
return -1;
- if (qemuSecurityCommandRun(driver, vm, cmd, -1, -1, false, NULL) < 0)
+ if (qemuSecurityCommandRun(driver, vm, cmd, -1, -1, true, NULL) < 0)
goto error;
return 0;
--
@@ -281,7 +281,7 @@ qemuPasstStart(virDomainObj *vm,
if (qemuExtDeviceLogCommand(driver, vm, cmd, "passt") < 0)
return -1;
- if (qemuSecurityCommandRun(driver, vm, cmd, -1, -1, false, NULL) < 0)
+ if (qemuSecurityCommandRun(driver, vm, cmd, -1, -1, true, NULL) < 0)
goto error;
return 0;
--
2.39.2
next prev parent reply other threads:[~2023-03-09 4:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 4:49 [libvirt PATCH 0/4] qemu/security: start passt process with correct SELinux label Laine Stump
2023-03-09 4:49 ` [libvirt PATCH 1/4] util: add an API to retrieve the resolved path to a virCommand's binary Laine Stump
2023-03-09 4:49 ` [libvirt PATCH 2/4] security: make args to virSecuritySELinuxContextAddRange() const Laine Stump
2023-03-09 4:49 ` [libvirt PATCH 3/4] security: make it possible to set SELinux label of child process from its binary Laine Stump
2023-03-09 4:49 ` Laine Stump [this message]
2023-03-09 5:06 ` [libvirt PATCH 0/4] qemu/security: start passt process with correct SELinux label Laine Stump
2023-03-10 11:58 ` Michal Prívozník
2023-03-10 14:39 ` Andrea Bolognani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230309044908.29316-5-laine@redhat.com \
--to=laine@redhat.com \
--cc=libvir-list@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).