From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id BBEBE5A026E for ; Tue, 21 Mar 2023 04:55:09 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Pgd6H5NXMz4x5R; Tue, 21 Mar 2023 14:55:03 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1679370903; bh=mwUJZ+TxjhZukebyA4vohpw++85DlAiCwXAQo3X5LCI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C8hpF/IHOjwqUVGbsYrdSYoQkPJM46Nksxtl0yPBItnTwEve+2QtpYhsfrt1Npp2f EfVav5DVNxehXlKtwt396awqBuNGVBZaCfhr1SMltTOO6d05tSsZvRPlA9ZKc0RoRc XS83KhnZkKHgPsU8EXAFUYPkOSbgPc/ky8pMTH6w= From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 2/2] Fix false positive if cppcheck doesn't give a false positive Date: Tue, 21 Mar 2023 14:55:00 +1100 Message-Id: <20230321035500.732872-3-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230321035500.732872-1-david@gibson.dropbear.id.au> References: <20230321035500.732872-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: WIH6D3GX23WUG4RBFVTKXN2N7FWWQCLY X-Message-ID-Hash: WIH6D3GX23WUG4RBFVTKXN2N7FWWQCLY X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: da46fdac "tcp: Suppress knownConditionTrueFalse cppcheck false positive" introduced a suppression to work around a cppcheck bug causing a false positive warning. However, the suppression will itself cause a spurious unmatchedSuppression warning if used with a version of cppcheck from before the bug was introduced. That includes the packaged version of cppcheck in Fedora. Suppress the unmatchedSuppression as well. Fixes: da46fdac Signed-off-by: David Gibson --- tcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcp.c b/tcp.c index 8551416..d5e6607 100644 --- a/tcp.c +++ b/tcp.c @@ -1822,7 +1822,7 @@ static void tcp_clamp_window(const struct ctx *c, struct tcp_tap_conn *conn, * * drop this suppression once that's resolved. */ - /* cppcheck-suppress knownConditionTrueFalse */ + /* cppcheck-suppress [knownConditionTrueFalse, unmatchedSuppression] */ if ((wnd > prev_scaled && wnd * 99 / 100 < prev_scaled) || (wnd < prev_scaled && wnd * 101 / 100 > prev_scaled)) return; -- 2.39.2