public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Paul Holzinger <pholzing@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] pasta: fix tcp port forwarding in auto mode
Date: Tue, 21 Mar 2023 09:18:48 +0100	[thread overview]
Message-ID: <20230321091848.4a982a40@elisabeth> (raw)
In-Reply-To: <20230320181034.87131-1-pholzing@redhat.com>

Thanks for the patch!

On Mon, 20 Mar 2023 19:10:34 +0100
Paul Holzinger <pholzing@redhat.com> wrote:

> The logic in tcp_timer() was inverted. fwd_out should expose the host
> ports in the ns. Therfore it must read the ports on the host and then
> bind them in the netns. The same for fwd_in which checks ports in the
> ns and then exposes them on the host.
> 
> Note that this only fixes tcp ports, udp does not seems to work at all
> right now with the auto mode.

Note that for UDP there's no periodic scan, "auto" just checks bound
ports when pasta starts:

       -u, --udp-ports spec
              Configure UDP port forwarding to namespace. spec is as described
              for TCP above, and the list of ports is derived  from  listening
              sockets   reported  by  /proc/net/udp  and  /proc/net/udp6,  see
              proc(5), when pasta starts (not periodically).

> Signed-off-by: Paul Holzinger <pholzing@redhat.com>

Fixes: 1128fa03fe73 ("Improve types and names for port forwarding configuration")

(I'll add that tag).

The patch itself looks good to me. I'm now looking at other parts
(tcp_sock_init()) where we seem to have the same kind of swap.

Unfortunately this is only covered by the Podman demo as a test, which
has been disabled for a while now:

  https://bugs.passt.top/show_bug.cgi?id=29

and as David is meanwhile working to improve the test framework, we can
probably wait a bit to introduce a new test. Meanwhile I'll check this
part manually on related changes.

-- 
Stefano


  reply	other threads:[~2023-03-21  8:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 18:10 [PATCH] pasta: fix tcp port forwarding in auto mode Paul Holzinger
2023-03-21  8:18 ` Stefano Brivio [this message]
2023-03-21 13:55   ` Paul Holzinger
2023-03-21 14:02     ` Stefano Brivio
2023-03-21 23:30       ` Stefano Brivio
2023-03-21 15:25   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230321091848.4a982a40@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).