From: Stefano Brivio <sbrivio@redhat.com>
To: Paul Holzinger <pholzing@redhat.com>
Cc: passt-dev@passt.top, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] pasta: fix tcp port forwarding in auto mode
Date: Tue, 21 Mar 2023 15:02:30 +0100 [thread overview]
Message-ID: <20230321150230.65b81eaf@elisabeth> (raw)
In-Reply-To: <462fd5de-1d51-2a1d-a5f7-aeb755dadb2e@redhat.com>
On Tue, 21 Mar 2023 14:55:17 +0100
Paul Holzinger <pholzing@redhat.com> wrote:
> On 21/03/2023 09:18, Stefano Brivio wrote:
> > Thanks for the patch!
> >
> > On Mon, 20 Mar 2023 19:10:34 +0100
> > Paul Holzinger <pholzing@redhat.com> wrote:
> >
> >> The logic in tcp_timer() was inverted. fwd_out should expose the host
> >> ports in the ns. Therfore it must read the ports on the host and then
> >> bind them in the netns. The same for fwd_in which checks ports in the
> >> ns and then exposes them on the host.
> >>
> >> Note that this only fixes tcp ports, udp does not seems to work at all
> >> right now with the auto mode.
> > Note that for UDP there's no periodic scan, "auto" just checks bound
> > ports when pasta starts:
> >
> > -u, --udp-ports spec
> > Configure UDP port forwarding to namespace. spec is as described
> > for TCP above, and the list of ports is derived from listening
> > sockets reported by /proc/net/udp and /proc/net/udp6, see
> > proc(5), when pasta starts (not periodically).
>
> Ok this makes sense then, is there a bug to track this? Because without
> it auto mode for UDP is useless for my Podman use case.
No, sorry, not yet, feel free to file one, or I can do that later
today.
Right now not even what the man page says works, I'll post a patch in a
bit.
--
Stefano
next prev parent reply other threads:[~2023-03-21 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 18:10 [PATCH] pasta: fix tcp port forwarding in auto mode Paul Holzinger
2023-03-21 8:18 ` Stefano Brivio
2023-03-21 13:55 ` Paul Holzinger
2023-03-21 14:02 ` Stefano Brivio [this message]
2023-03-21 23:30 ` Stefano Brivio
2023-03-21 15:25 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321150230.65b81eaf@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).