From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 1/2] Work around weird false positives with cppcheck-2.9.1
Date: Tue, 21 Mar 2023 16:42:16 +0100 [thread overview]
Message-ID: <20230321164216.28d4d82e@elisabeth> (raw)
In-Reply-To: <20230321035500.732872-2-david@gibson.dropbear.id.au>
On Tue, 21 Mar 2023 14:54:59 +1100
David Gibson <david@gibson.dropbear.id.au> wrote:
> Commit 89e38f55 "treewide: Fix header includes to build with musl" added
> extra #includes to work with musl. Unfortunately with the cppcheck version
> I'm using (cppcheck-2.9-1.fc37.x86_64 in Fedora 37) this causes weird false
> positives: specifically cppcheck seems to hit a #error in <bits/unistd.h>
> complaining about including it directly instead of via <unistd.h> (which is
> not something we're doing).
>
> I have no idea why that would be happening; but I'm guessing it has to be
> a bug in the cpp implementation in that cppcheck version. In any case,
> it's possible to work around this by moving the include of <unistd.h>
> before the include of <signal.h>. So, do that.
Checked on Alpine, build against musl still works with this. Applied,
I'll push it out in a bit.
--
Stefano
next prev parent reply other threads:[~2023-03-21 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 3:54 [PATCH 0/2] Fix some problems with cppcheck-2.9.1 (from Fedora 37) David Gibson
2023-03-21 3:54 ` [PATCH 1/2] Work around weird false positives with cppcheck-2.9.1 David Gibson
2023-03-21 15:42 ` Stefano Brivio [this message]
2023-03-21 3:55 ` [PATCH 2/2] Fix false positive if cppcheck doesn't give a false positive David Gibson
2023-03-21 15:42 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321164216.28d4d82e@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).