From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 5FC455A0262 for ; Tue, 21 Mar 2023 16:43:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679413387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fCzEYf1NoBbvqJIuKRCkDapz8TDFQfCROY353abgm7k=; b=UbDVnHKNjUZ5+p3stuQf0ZtLHBUTqD9755S1R9FLwGTIgreG91si6mHSEujn4K5+2upMPe yJ/854L0Zu0AYtuRRlu30EXOYuX/07oTTGsBLdhIsg7a4xT2LHTReJA5CupN6vHAnLjm+J k0GMb5qvnPVW+uijLMM0+0ZK+RawXhY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-389-qG772zMHNkuSyCZjAEifpQ-1; Tue, 21 Mar 2023 11:43:05 -0400 X-MC-Unique: qG772zMHNkuSyCZjAEifpQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 57244185A7B3; Tue, 21 Mar 2023 15:43:05 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2BE6A492C13; Tue, 21 Mar 2023 15:43:05 +0000 (UTC) Date: Tue, 21 Mar 2023 16:42:53 +0100 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 2/2] Fix false positive if cppcheck doesn't give a false positive Message-ID: <20230321164253.0b5004f7@elisabeth> In-Reply-To: <20230321035500.732872-3-david@gibson.dropbear.id.au> References: <20230321035500.732872-1-david@gibson.dropbear.id.au> <20230321035500.732872-3-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: UEVIDAVBCRDPIQNFJLP5OBXGOLPWTPB4 X-Message-ID-Hash: UEVIDAVBCRDPIQNFJLP5OBXGOLPWTPB4 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 21 Mar 2023 14:55:00 +1100 David Gibson wrote: > da46fdac "tcp: Suppress knownConditionTrueFalse cppcheck false positive" > introduced a suppression to work around a cppcheck bug causing a false > positive warning. However, the suppression will itself cause a spurious > unmatchedSuppression warning if used with a version of cppcheck from before > the bug was introduced. That includes the packaged version of cppcheck in > Fedora. > > Suppress the unmatchedSuppression as well. Oops, I always forget about those. Applied. -- Stefano