From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 0/2] tcp: Correct handling of first ACK (or SYN-ACK) packet
Date: Mon, 27 Mar 2023 14:56:32 +1100 [thread overview]
Message-ID: <20230327035634.1432064-1-david@gibson.dropbear.id.au> (raw)
We have a subtle problem in the handling of the very first ack-flagged
packet (either the SYN-ACK or ACK from the three way handshake).
Stefano has posted a couple of versions of a patch addressing this,
however I think this is a better approach. From the TCP logical point
of view, that first ACK does advance the sequence number, and if we
treat it as doing so, then the logic we already had in
tcp_update_seqack_from_tap() is correct.
David Gibson (2):
tcp: Clarify allowed state for tcp_data_from_tap()
tcp: Don't special case the handling of the ack of a syn
tcp.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
--
2.39.2
next reply other threads:[~2023-03-27 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 3:56 David Gibson [this message]
2023-03-27 3:56 ` [PATCH 1/2] tcp: Clarify allowed state for tcp_data_from_tap() David Gibson
2023-03-27 3:56 ` [PATCH 2/2] tcp: Don't special case the handling of the ack of a syn David Gibson
2023-03-27 9:15 ` [PATCH 0/2] tcp: Correct handling of first ACK (or SYN-ACK) packet Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327035634.1432064-1-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).