From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 8D0DC5A026D for ; Tue, 4 Apr 2023 03:46:50 +0200 (CEST) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Pr9bj4ZdTz4xFm; Tue, 4 Apr 2023 11:46:41 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1680572801; bh=cLT3xbUsTOV7om6/bYskEoSN2RXwm3GRCehkoq+WQbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l053pfmvCGggH6PV9MZmd4/nDGcbUHpRDCMt6j8vvsGHxtpZyF7uLjRHBsplajKk7 vFKRQt+CRDRKSGmDJCKqOXD/jHwZVcDfsLfbhO8ySENe3RmPxCx/xziudYsZFU8agD SNdFb7YpV0OmFn2L9XZfTl57bSZ6JWa4ZKy6cd4k= From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 11/14] test: Initialise ${TRACE} properly Date: Tue, 4 Apr 2023 11:46:35 +1000 Message-Id: <20230404014638.3225556-12-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404014638.3225556-1-david@gibson.dropbear.id.au> References: <20230404014638.3225556-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: S6KKBRI7CMIIHJNWX5LLO5BTTT2OMHX3 X-Message-ID-Hash: S6KKBRI7CMIIHJNWX5LLO5BTTT2OMHX3 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Unlike ${DEBUG} we don't initialize ${TRACE} to 0 if not set, which cases failures when testing it later. That failure acts as though it is false, however it emits spurious errors in script.log, which can make it harder to spot real errors. Signed-off-by: David Gibson --- test/run | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/run b/test/run index e07513f..1945c7b 100755 --- a/test/run +++ b/test/run @@ -32,6 +32,9 @@ FAST=${FAST:-1} # If set, run passt and pasta with debug options DEBUG=${DEBUG:-0} +# If set, run passt and pasta with trace options +TRACE=${TRACE:-0} + # If set, tell passt and pasta to take packet captures PCAP=${PCAP:-0} -- 2.39.2