public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 07/14] nstool: Add magic number to advertized information
Date: Tue,  4 Apr 2023 11:46:31 +1000	[thread overview]
Message-ID: <20230404014638.3225556-8-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20230404014638.3225556-1-david@gibson.dropbear.id.au>

So that we'll probably give a better error if you point it at something
that's not an nstool hold control socket.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 test/nstool.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/test/nstool.c b/test/nstool.c
index 428c9c4..e995f3e 100644
--- a/test/nstool.c
+++ b/test/nstool.c
@@ -12,6 +12,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>
+#include <stdint.h>
 #include <errno.h>
 #include <unistd.h>
 #include <getopt.h>
@@ -45,7 +46,10 @@ const struct ns_type nstypes[] = {
 	{ CLONE_NEWUTS, "uts" },
 };
 
+#define NSTOOL_MAGIC	0x75601d75
+
 struct holder_info {
+	uint64_t magic;
 	pid_t pid;
 	uid_t uid;
 	gid_t gid;
@@ -101,6 +105,10 @@ static int connect_ctl(const char *sockpath, bool wait,
 	if ((size_t)len < sizeof(*info))
 		die("short read() on control socket %s\n", sockpath);
 
+	if (info->magic != NSTOOL_MAGIC)
+		die("Control socket %s doesn't appear to belong to nstool\n",
+		    sockpath);
+
 	if (peercred) {
 		socklen_t optlen = sizeof(*peercred);
 
@@ -140,6 +148,7 @@ static void cmd_hold(int argc, char *argv[])
 	if (rc < 0)
 		die("listen() on %s: %s\n", sockpath, strerror(errno));
 
+	info.magic = NSTOOL_MAGIC;
 	info.pid = getpid();
 	info.uid = getuid();
 	info.gid = getgid();
-- 
@@ -12,6 +12,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <stdbool.h>
+#include <stdint.h>
 #include <errno.h>
 #include <unistd.h>
 #include <getopt.h>
@@ -45,7 +46,10 @@ const struct ns_type nstypes[] = {
 	{ CLONE_NEWUTS, "uts" },
 };
 
+#define NSTOOL_MAGIC	0x75601d75
+
 struct holder_info {
+	uint64_t magic;
 	pid_t pid;
 	uid_t uid;
 	gid_t gid;
@@ -101,6 +105,10 @@ static int connect_ctl(const char *sockpath, bool wait,
 	if ((size_t)len < sizeof(*info))
 		die("short read() on control socket %s\n", sockpath);
 
+	if (info->magic != NSTOOL_MAGIC)
+		die("Control socket %s doesn't appear to belong to nstool\n",
+		    sockpath);
+
 	if (peercred) {
 		socklen_t optlen = sizeof(*peercred);
 
@@ -140,6 +148,7 @@ static void cmd_hold(int argc, char *argv[])
 	if (rc < 0)
 		die("listen() on %s: %s\n", sockpath, strerror(errno));
 
+	info.magic = NSTOOL_MAGIC;
 	info.pid = getpid();
 	info.uid = getuid();
 	info.gid = getgid();
-- 
2.39.2


  parent reply	other threads:[~2023-04-04  1:46 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04  1:46 [PATCH 00/14] Improved tool for testing across multiple namespaces David Gibson
2023-04-04  1:46 ` [PATCH 01/14] nstool: Rename nsholder to nstool David Gibson
2023-04-04  1:46 ` [PATCH 02/14] nstool: Reverse parameters " David Gibson
2023-04-04  1:46 ` [PATCH 03/14] nstool: Move description of its operation modes from comment to usage David Gibson
2023-04-05 11:56   ` Stefano Brivio
2023-04-06  0:10     ` David Gibson
2023-04-04  1:46 ` [PATCH 04/14] nstool: Split some command line parsing and socket setup to subcommands David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  2:31     ` David Gibson
2023-04-06  6:47       ` Stefano Brivio
2023-04-06 10:35         ` David Gibson
2023-04-04  1:46 ` [PATCH 05/14] nstool: Replace "pid" subcommand with "info" subcommand David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:13     ` David Gibson
2023-04-04  1:46 ` [PATCH 06/14] nstool: Detect what namespaces target is in David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:15     ` David Gibson
2023-04-04  1:46 ` David Gibson [this message]
2023-04-05 11:58   ` [PATCH 07/14] nstool: Add magic number to advertized information Stefano Brivio
2023-04-06  0:18     ` David Gibson
2023-04-04  1:46 ` [PATCH 08/14] nstool: Helpers to iterate through namespace types David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:55     ` David Gibson
2023-04-04  1:46 ` [PATCH 09/14] nstool: Add nstool exec command to execute commands in an nstool namespace David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:59     ` David Gibson
2023-04-04  1:46 ` [PATCH 10/14] nstool: Add --keep-caps option to nstool exec David Gibson
2023-04-05 11:59   ` Stefano Brivio
2023-04-06  1:11     ` David Gibson
2023-04-04  1:46 ` [PATCH 11/14] test: Initialise ${TRACE} properly David Gibson
2023-04-04  1:46 ` [PATCH 12/14] test: Use "nstool exec" to slightly simplify tests David Gibson
2023-04-05 11:59   ` Stefano Brivio
2023-04-06  1:14     ` David Gibson
2023-04-04  1:46 ` [PATCH 13/14] nstool: Advertise the holder's cwd (in its mountns) across the socket David Gibson
2023-04-04  1:46 ` [PATCH 14/14] nstool: Enter holder's cwd when changing mount ns with nstool exec David Gibson
2023-04-05 12:01 ` [PATCH 00/14] Improved tool for testing across multiple namespaces Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230404014638.3225556-8-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).