From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 58B765A026D for ; Wed, 5 Apr 2023 13:57:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680695826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zAamHvo4UVQKuBkBGfDJGdX1J/pSosO6qF6habQrg/E=; b=MzPuaT+uflJOEH0r4/OQRGc1ZeFXvZZ/mIiD0GIUBbgXUv6yPGvKW0sSAxR/p49PNlTQm5 eP4KSUNVdDbi9KxbdEU8EulJyddulg0AmCrel/7Pbp+l97rcRQfpvcgT/ogo15D49ijtJe T+0c0oGJQAa0HkFDWuvaDK7y/nKsJKk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-3x0rj6lKMb6CKDMdgt5CZA-1; Wed, 05 Apr 2023 07:57:04 -0400 X-MC-Unique: 3x0rj6lKMb6CKDMdgt5CZA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B6B6101A551; Wed, 5 Apr 2023 11:57:04 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87B5E202701F; Wed, 5 Apr 2023 11:57:03 +0000 (UTC) Date: Wed, 5 Apr 2023 13:56:59 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 03/14] nstool: Move description of its operation modes from comment to usage Message-ID: <20230405135648.00a7e1dc@elisabeth> In-Reply-To: <20230404014638.3225556-4-david@gibson.dropbear.id.au> References: <20230404014638.3225556-1-david@gibson.dropbear.id.au> <20230404014638.3225556-4-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: EGQPTGTZLGVZTUGF2RQDVAMLMAZ3UXGJ X-Message-ID-Hash: EGQPTGTZLGVZTUGF2RQDVAMLMAZ3UXGJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 4 Apr 2023 11:46:27 +1000 David Gibson wrote: > Easier to see it there. > > Signed-off-by: David Gibson > --- > test/nstool.c | 26 +++++++++++--------------- > 1 file changed, 11 insertions(+), 15 deletions(-) > > diff --git a/test/nstool.c b/test/nstool.c > index cc6d617..7e069b6 100644 > --- a/test/nstool.c > +++ b/test/nstool.c > @@ -4,20 +4,6 @@ > * > * Copyright Red Hat > * Author: David Gibson > - * > - * Can run in 3 modes: > - * > - * nstool hold > - * Designed to be run inside a namespace, opens a Unix domain > - * control socket at and waits until instructed to stop > - * with "nstool stop " > - * nstool pid > - * Prints the PID of the nstool hold process with control socket > - * . This is given in the PID namespace where nstool pid > - * is executed, not the one where nstool hold is running > - * nstool stop > - * Instruct the nstool hold with control socket at to > - * exit. > */ > > #define _GNU_SOURCE > @@ -38,7 +24,17 @@ > > static void usage(void) > { > - die("Usage: nstool hold|pid|stop \n"); > + die("Usage:\n" > + " nstool hold SOCK\n" > + " Run within a set of namespaces, open a Unix domain control\n" UNIX domain socket -- Stefano