Re: [PATCH 00/14] Improved tool for testing across multiple namespaces

[Stefano Brivio <sbrivio@redhat.com>]

On Tue,  4 Apr 2023 11:46:24 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> This series extends the "nsholder" tool we use in the tests to
> "nstool" with some more features.  In particular it allows entering an
> established namespace with capabilities intact, and it allows entering
> them with less verbose options than nsenter.
> 
> For now this only gives a modest simplification of the tests, but it
> should enable more in future.
> 
> I haven't managed to get all the way through the testsuite with this:
> it's wedging in the IPv4 UDP throughput tests, but that's happening
> for me with the main branch too.  I'll debug that, but I don't want to
> delay this series on that for now.
> 
> David Gibson (14):
>   nstool: Rename nsholder to nstool
>   nstool: Reverse parameters to nstool
>   nstool: Move description of its operation modes from comment to usage
>   nstool: Split some command line parsing and socket setup to
>     subcommands
>   nstool: Replace "pid" subcommand with "info" subcommand
>   nstool: Detect what namespaces target is in
>   nstool: Add magic number to advertized information
>   nstool: Helpers to iterate through namespace types
>   nstool: Add nstool exec command to execute commands in an nstool
>     namespace
>   nstool: Add --keep-caps option to nstool exec
>   test: Initialise ${TRACE} properly
>   test: Use "nstool exec" to slightly simplify tests
>   nstool: Advertise the holder's cwd (in its mountns) across the socket
>   nstool: Enter holder's cwd when changing mount ns with nstool exec

In general this series looks good to me. None of the comments I have
should actually impact functionality, so I can also apply as it is for
the moment, I don't want to stand in the way of progress (and focus) --
as you prefer.

-- 
Stefano