From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id B13025A026D for ; Wed, 5 Apr 2023 14:01:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680696097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oTO/VuYkdhJHR81xNXvx24QDHO+0Ov0RCbywTUeulfM=; b=acm2ZswuG7sqp8pbkF9gLLQW+636LkogRyuzYXTL0BHQES+g9C0Z0SA9hzvXOhmYrWwpOz EK7MjpQTLoP5mOvlGtoNTWN7YwfjQMANT8v9T0Y6uUaE6uWUzbaL2H8O6T94EKg035I/hm zGeH/m8KPn16wstap1scAZeeHKK6NOQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-489-RWUWl6oUPn-dRzzsTNOo3w-1; Wed, 05 Apr 2023 08:01:34 -0400 X-MC-Unique: RWUWl6oUPn-dRzzsTNOo3w-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3214288B7A0; Wed, 5 Apr 2023 12:01:34 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.33]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 91BEA40104E; Wed, 5 Apr 2023 12:01:33 +0000 (UTC) Date: Wed, 5 Apr 2023 14:01:23 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 00/14] Improved tool for testing across multiple namespaces Message-ID: <20230405140123.71090ddf@elisabeth> In-Reply-To: <20230404014638.3225556-1-david@gibson.dropbear.id.au> References: <20230404014638.3225556-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PJBDZAFOESKN5LOEU47GB2GR6C2624PX X-Message-ID-Hash: PJBDZAFOESKN5LOEU47GB2GR6C2624PX X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 4 Apr 2023 11:46:24 +1000 David Gibson wrote: > This series extends the "nsholder" tool we use in the tests to > "nstool" with some more features. In particular it allows entering an > established namespace with capabilities intact, and it allows entering > them with less verbose options than nsenter. > > For now this only gives a modest simplification of the tests, but it > should enable more in future. > > I haven't managed to get all the way through the testsuite with this: > it's wedging in the IPv4 UDP throughput tests, but that's happening > for me with the main branch too. I'll debug that, but I don't want to > delay this series on that for now. > > David Gibson (14): > nstool: Rename nsholder to nstool > nstool: Reverse parameters to nstool > nstool: Move description of its operation modes from comment to usage > nstool: Split some command line parsing and socket setup to > subcommands > nstool: Replace "pid" subcommand with "info" subcommand > nstool: Detect what namespaces target is in > nstool: Add magic number to advertized information > nstool: Helpers to iterate through namespace types > nstool: Add nstool exec command to execute commands in an nstool > namespace > nstool: Add --keep-caps option to nstool exec > test: Initialise ${TRACE} properly > test: Use "nstool exec" to slightly simplify tests > nstool: Advertise the holder's cwd (in its mountns) across the socket > nstool: Enter holder's cwd when changing mount ns with nstool exec In general this series looks good to me. None of the comments I have should actually impact functionality, so I can also apply as it is for the moment, I don't want to stand in the way of progress (and focus) -- as you prefer. -- Stefano