public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 04/14] nstool: Split some command line parsing and socket setup to subcommands
Date: Thu, 6 Apr 2023 08:47:48 +0200	[thread overview]
Message-ID: <20230406084748.5812c233@elisabeth> (raw)
In-Reply-To: <ZC4vG3QZgQfO5uM1@yekko>

On Thu, 6 Apr 2023 12:31:55 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Wed, Apr 05, 2023 at 01:58:00PM +0200, Stefano Brivio wrote:
>
> [...]
>
> > I didn't spot this earlier, but... does it really make sense to wait in
> > cmd_pid(), also on ENOENT, rather than making 'hold' return only once
> > the socket is ready?  
> 
> So, this is a consequence of the fact that the holder doesn't move
> into the background itself - it just sits in the foreground until
> terminated.  That means that the typical usecase puts it into the
> background from the shell with &, which in turn means that when we
> reach the next shell command the socket may not be ready - or not even
> created.
> 
> One of the things I had in mind for a hypothetical "nstool unshare"
> would be to avoid this and have it background itself once the socket
> is ready.

Ah, sure, it makes sense now.

> > I don't think it would be outrageous to have
> > 'nstool pid' failing if the holding process doesn't exist.
> > 
> > Admittely, I'm biased by the few hundreds of times I needed to
> > 'killall -9 nsholder' in the past months. :)  
> 
> So... I agree that's irritating, I've done it a similar number of
> times.  However, I don't think that's really related to the question
> above - in my experience it's always been the holder process that's
> hung around, not something waiting on a holder.

Yes, same here, but it's something I file under the same category (I
don't remember why nsholder would hang, you probably explained at some
point...).

> > >  	rc = getsockopt(fd, SOL_SOCKET, SO_PEERCRED,
> > >  			&peercred, &optlen);
> > >  	if (rc < 0)
> > > -		die("getsockopet(SO_PEERCRED): %s\n", strerror(errno));
> > > +		die("getsockopet(SO_PEERCRED) %s: %s\n",
> > > +		    sockpath, strerror(errno));
> > >  
> > >  	close(fd);
> > >  
> > >  	printf("%d\n", peercred.pid);
> > >  }
> > >  
> > > -static void stop(int fd, const struct sockaddr_un *addr)
> > > +static void cmd_stop(int argc, char *argv[])
> > >  {
> > > -	int rc;
> > > +	const char *sockpath = argv[1];
> > > +	int fd, rc;
> > >  	char buf = 'Q';
> > >  
> > > -	rc = connect(fd, (struct sockaddr *)addr, sizeof(*addr));
> > > -	if (rc < 0)
> > > -		die("connect(): %s\n", strerror(errno));
> > > +	if (argc != 2)
> > > +		usage();
> > > +
> > > +	fd = connect_ctl(sockpath, false);
> > >  
> > >  	rc = write(fd, &buf, sizeof(buf));  
> > 
> > Unrelated: a compound literal would make this more readable.  
> 
> Uh.. I don't see where a compound literal would even go here.

I meant:

	rc = write(fd, &(char){ 'Q' }, 1);

...so that one doesn't need to look at 'buf'. nstool is C99 anyway.

-- 
Stefano


  reply	other threads:[~2023-04-06  6:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04  1:46 [PATCH 00/14] Improved tool for testing across multiple namespaces David Gibson
2023-04-04  1:46 ` [PATCH 01/14] nstool: Rename nsholder to nstool David Gibson
2023-04-04  1:46 ` [PATCH 02/14] nstool: Reverse parameters " David Gibson
2023-04-04  1:46 ` [PATCH 03/14] nstool: Move description of its operation modes from comment to usage David Gibson
2023-04-05 11:56   ` Stefano Brivio
2023-04-06  0:10     ` David Gibson
2023-04-04  1:46 ` [PATCH 04/14] nstool: Split some command line parsing and socket setup to subcommands David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  2:31     ` David Gibson
2023-04-06  6:47       ` Stefano Brivio [this message]
2023-04-06 10:35         ` David Gibson
2023-04-04  1:46 ` [PATCH 05/14] nstool: Replace "pid" subcommand with "info" subcommand David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:13     ` David Gibson
2023-04-04  1:46 ` [PATCH 06/14] nstool: Detect what namespaces target is in David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:15     ` David Gibson
2023-04-04  1:46 ` [PATCH 07/14] nstool: Add magic number to advertized information David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:18     ` David Gibson
2023-04-04  1:46 ` [PATCH 08/14] nstool: Helpers to iterate through namespace types David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:55     ` David Gibson
2023-04-04  1:46 ` [PATCH 09/14] nstool: Add nstool exec command to execute commands in an nstool namespace David Gibson
2023-04-05 11:58   ` Stefano Brivio
2023-04-06  0:59     ` David Gibson
2023-04-04  1:46 ` [PATCH 10/14] nstool: Add --keep-caps option to nstool exec David Gibson
2023-04-05 11:59   ` Stefano Brivio
2023-04-06  1:11     ` David Gibson
2023-04-04  1:46 ` [PATCH 11/14] test: Initialise ${TRACE} properly David Gibson
2023-04-04  1:46 ` [PATCH 12/14] test: Use "nstool exec" to slightly simplify tests David Gibson
2023-04-05 11:59   ` Stefano Brivio
2023-04-06  1:14     ` David Gibson
2023-04-04  1:46 ` [PATCH 13/14] nstool: Advertise the holder's cwd (in its mountns) across the socket David Gibson
2023-04-04  1:46 ` [PATCH 14/14] nstool: Enter holder's cwd when changing mount ns with nstool exec David Gibson
2023-04-05 12:01 ` [PATCH 00/14] Improved tool for testing across multiple namespaces Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230406084748.5812c233@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).