From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id C67D15A026D for ; Sat, 8 Apr 2023 01:13:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680909181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=idG3IrmOjKBkqs+cyg5mNqKv/xrArjFWbz68EenhCB0=; b=Us2WlmksQ3y/sNQVXkjVhupzPEcTUXnhBVQM5/hXhaqV/quc1qS/AoH0m4jyRz8muTJnRX QddTvn3y5xl1Mmn0Zxuq1801F0TaBTrqVZnHtLMI19a3GM/CquNUaJmvUYTVsqKwPlvuIW 61Jwmta7qMIG5tqv2IJ8RrGsuHETp6Y= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-5-eVv5-_WxNOyayM8A-GDurA-1; Fri, 07 Apr 2023 19:12:59 -0400 X-MC-Unique: eVv5-_WxNOyayM8A-GDurA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75C203806708; Fri, 7 Apr 2023 23:12:59 +0000 (UTC) Received: from maya.cloud.tilaa.com (unknown [10.33.32.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C66414171BE; Fri, 7 Apr 2023 23:12:58 +0000 (UTC) Date: Sat, 8 Apr 2023 01:12:56 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 00/14] Improved tool for testing across multiple namespaces Message-ID: <20230408011256.455ec451@elisabeth> In-Reply-To: <20230406032819.707441-1-david@gibson.dropbear.id.au> References: <20230406032819.707441-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NIQKZH5QVC3ZPNGQVBGSE4VAVNVA3SOJ X-Message-ID-Hash: NIQKZH5QVC3ZPNGQVBGSE4VAVNVA3SOJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 6 Apr 2023 13:28:05 +1000 David Gibson wrote: > This series extends the "nsholder" tool we use in the tests to > "nstool" with some more features. In particular it allows entering an > established namespace with capabilities intact, and it allows entering > them with less verbose options than nsenter. > > For now this only gives a modest simplification of the tests, but it > should enable more in future. > > I haven't managed to get all the way through the testsuite with this: > it's wedging in the IPv4 UDP throughput tests, but that's happening > for me with the main branch too. I'll debug that, but I don't want to > delay this series on that for now. > > Changes since v1: > * Fixed a bunch of bad indentation from a bad copy/paste > * Assorted minor cleanups based on review from Stefano > > David Gibson (14): > nstool: Rename nsholder to nstool > nstool: Reverse parameters to nstool > nstool: Move description of its operation modes from comment to usage > nstool: Split some command line parsing and socket setup to > subcommands > nstool: Replace "pid" subcommand with "info" subcommand > nstool: Detect what namespaces target is in > nstool: Add magic number to advertized information > nstool: Helpers to iterate through namespace types > nstool: Add nstool exec command to execute commands in an nstool > namespace > nstool: Add --keep-caps option to nstool exec > test: Initialise ${TRACE} properly > test: Use "nstool exec" to slightly simplify tests > nstool: Advertise the holder's cwd (in its mountns) across the socket > nstool: Enter holder's cwd when changing mount ns with nstool exec Pushed, thanks. -- Stefano