From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] test: Remove race between commands run in the same context
Date: Sat, 8 Apr 2023 01:13:14 +0200 [thread overview]
Message-ID: <20230408011314.3ed17f28@elisabeth> (raw)
In-Reply-To: <20230405015642.406952-1-david@gibson.dropbear.id.au>
On Wed, 5 Apr 2023 11:56:42 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> context_run() has a race condition if two commands are run in close
> proximity (generally involving at least one in the background). Because we
> always use the same name for the temporary fifo files, if another command
> is issued while the fifos for the first still exist, mkfifo will fail,
> typically causing the entire test script to jam.
>
> Create unique names for the temporary fifos to avoid this problem.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Also applied.
--
Stefano
prev parent reply other threads:[~2023-04-07 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 1:56 [PATCH] test: Remove race between commands run in the same context David Gibson
2023-04-05 12:23 ` Stefano Brivio
2023-04-06 1:15 ` David Gibson
2023-04-07 23:13 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230408011314.3ed17f28@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).