From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 3/7] avocado: Move static checkers to avocado
Date: Thu, 20 Apr 2023 11:11:04 +1000 [thread overview]
Message-ID: <20230420011108.494181-4-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20230420011108.494181-1-david@gibson.dropbear.id.au>
Move these, the simplest of our tests, to be run from avocado rather than
our hand-rolled test harness.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
Makefile | 10 ++++++++++
avocado/static_checkers/clang-tidy.sh | 3 +++
avocado/static_checkers/cppcheck.sh | 3 +++
oldtest/run | 4 ++--
test/build/clang_tidy | 17 -----------------
test/build/cppcheck | 17 -----------------
test/run | 2 --
7 files changed, 18 insertions(+), 38 deletions(-)
create mode 100755 avocado/static_checkers/clang-tidy.sh
create mode 100755 avocado/static_checkers/cppcheck.sh
delete mode 100644 test/build/clang_tidy
delete mode 100644 test/build/cppcheck
diff --git a/Makefile b/Makefile
index a5256f5..0fd9fe9 100644
--- a/Makefile
+++ b/Makefile
@@ -294,3 +294,13 @@ cppcheck: $(SRCS) $(HEADERS)
--suppress=unusedStructMember \
$(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \
.
+
+AVOCADO = avocado
+
+.PHONY: avocado
+avocado:
+ $(MAKE) -C test
+ $(AVOCADO) run avocado
+
+check: avocado
+ $(MAKE) -C test check
diff --git a/avocado/static_checkers/clang-tidy.sh b/avocado/static_checkers/clang-tidy.sh
new file mode 100755
index 0000000..67bcf27
--- /dev/null
+++ b/avocado/static_checkers/clang-tidy.sh
@@ -0,0 +1,3 @@
+#! /bin/sh
+
+make clang-tidy
diff --git a/avocado/static_checkers/cppcheck.sh b/avocado/static_checkers/cppcheck.sh
new file mode 100755
index 0000000..2c6d396
--- /dev/null
+++ b/avocado/static_checkers/cppcheck.sh
@@ -0,0 +1,3 @@
+#! /bin/sh
+
+make cppcheck
diff --git a/oldtest/run b/oldtest/run
index 75309f6..56fcd1b 100755
--- a/oldtest/run
+++ b/oldtest/run
@@ -66,8 +66,8 @@ run() {
setup build
# test build/all
-# test build/cppcheck
-# test build/clang_tidy
+ test build/cppcheck
+ test build/clang_tidy
teardown build
# setup pasta
diff --git a/test/build/clang_tidy b/test/build/clang_tidy
deleted file mode 100644
index 40573bf..0000000
--- a/test/build/clang_tidy
+++ /dev/null
@@ -1,17 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
-#
-# PASST - Plug A Simple Socket Transport
-# for qemu/UNIX domain socket mode
-#
-# PASTA - Pack A Subtle Tap Abstraction
-# for network namespace/tap device mode
-#
-# test/build/clang_tidy - Run source through clang-tidy(1) linter
-#
-# Copyright (c) 2021 Red Hat GmbH
-# Author: Stefano Brivio <sbrivio@redhat.com>
-
-htools clang-tidy
-
-test Run clang-tidy
-host make clang-tidy
diff --git a/test/build/cppcheck b/test/build/cppcheck
deleted file mode 100644
index 0e1dbce..0000000
--- a/test/build/cppcheck
+++ /dev/null
@@ -1,17 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-or-later
-#
-# PASST - Plug A Simple Socket Transport
-# for qemu/UNIX domain socket mode
-#
-# PASTA - Pack A Subtle Tap Abstraction
-# for network namespace/tap device mode
-#
-# test/build/cppcheck - Run source through cppcheck(1) linter
-#
-# Copyright (c) 2021 Red Hat GmbH
-# Author: Stefano Brivio <sbrivio@redhat.com>
-
-htools cppcheck
-
-test Run cppcheck
-host make cppcheck
diff --git a/test/run b/test/run
index 8f4f845..ce24f44 100755
--- a/test/run
+++ b/test/run
@@ -66,8 +66,6 @@ run() {
setup build
test build/all
- test build/cppcheck
- test build/clang_tidy
teardown build
setup pasta
--
@@ -66,8 +66,6 @@ run() {
setup build
test build/all
- test build/cppcheck
- test build/clang_tidy
teardown build
setup pasta
--
2.40.0
next prev parent reply other threads:[~2023-04-20 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 1:11 [PATCH 0/7] RFC: Proof-of-concept conversion of some tests to Avocado framework David Gibson
2023-04-20 1:11 ` [PATCH 1/7] avocado: Make a duplicate copy of testsuite for comparison purposes David Gibson
2023-04-20 1:11 ` [PATCH 2/7] avocado: Don't double download assets for test/ and oldtest/ David Gibson
2023-04-20 1:11 ` David Gibson [this message]
2023-04-20 1:11 ` [PATCH 4/7] avocado: Convert build tests to avocado David Gibson
2023-04-20 1:11 ` [PATCH 5/7] avocado: Helper functions and classes to run commands via nstool David Gibson
2023-04-20 1:11 ` [PATCH 6/7] avocado: Helper to get link-local address and wait for SLAAC to complete David Gibson
2023-04-20 1:11 ` [PATCH 7/7] avocado: Convert pasta transfer tests to Avocado David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230420011108.494181-4-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).