From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id D903E5A0262 for ; Tue, 2 May 2023 23:52:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683064334; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n3LnDjo0bJmshwNyqRJ6KDxnPpD0oak/XpbXFvvQgGk=; b=IDeCA89KcckIfZdChHApgXqTjx12k/42OQu/gy8XWD+egaevbhd8QVqndAaQQQtJcUENgn /oel8CCk0u+usvDhJ7vpIDTCSSD9JcuLsxRKvwoTxE38MB9Vzh03Ax6ssDKvP6b9r7houC CYShlUc2BT0rjKmUe4YSqb6CRLixSa4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-587-5E1LDZLINvKcaaMymdQ59Q-1; Tue, 02 May 2023 17:52:13 -0400 X-MC-Unique: 5E1LDZLINvKcaaMymdQ59Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2D2651C04185; Tue, 2 May 2023 21:52:13 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.2]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 657DEC15BAE; Tue, 2 May 2023 21:52:11 +0000 (UTC) Date: Tue, 2 May 2023 23:52:10 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/7] RFC: Allow NAT-to-host address to be configured explicitly Message-ID: <20230502235210.2c8aca62@elisabeth> In-Reply-To: <20230501110702.3915529-1-david@gibson.dropbear.id.au> References: <20230501110702.3915529-1-david@gibson.dropbear.id.au> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: OL7DZEPTGM35SWIUQERD7J43LXMQQWT3 X-Message-ID-Hash: OL7DZEPTGM35SWIUQERD7J43LXMQQWT3 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 1 May 2023 21:06:55 +1000 David Gibson wrote: > This isn't quite ready for merge yet. First, I think there might be a > bug I haven't managed to track down yet which causes intermittent > failures in some of the UDP throughput tests. I couldn't find any obvious offender at a quick glance, but I still have to convince myself that 2/7 is correct (mostly in the sense of "are those addresses always valid?"). I'll give another try at reviewing this tomorrow. -- Stefano