From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: jarichte@redhat.com, Cleber Rosa <crosa@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 11/21] avocado/tasst: Add ifup and network address helpers to Site
Date: Tue, 16 May 2023 12:01:25 +1000 [thread overview]
Message-ID: <20230516020135.1901256-12-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20230516020135.1901256-1-david@gibson.dropbear.id.au>
Add a helper to bring network interfaces up on a site, and to retrieve
configured IP addresses.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
avocado/tasst/nstool.py | 1 +
avocado/tasst/site.py | 29 +++++++++++++++++++++++++++++
2 files changed, 30 insertions(+)
diff --git a/avocado/tasst/nstool.py b/avocado/tasst/nstool.py
index 96ed2bd..5da2ffc 100644
--- a/avocado/tasst/nstool.py
+++ b/avocado/tasst/nstool.py
@@ -107,6 +107,7 @@ class IsolatedNetTasst(BaseSiteTasst):
"""
def subsetup(self, site):
+ site.ifup('lo')
Tasst.subsetup(self, IsolatedNetTasst, site)
BaseSiteTasst.subsetup(self, site)
diff --git a/avocado/tasst/site.py b/avocado/tasst/site.py
index 841efbe..5a63b76 100644
--- a/avocado/tasst/site.py
+++ b/avocado/tasst/site.py
@@ -10,6 +10,7 @@
# Copyright Red Hat
# Author: David Gibson <david@gibson.dropbear.id.au>
+import ipaddress
import json
import avocado
@@ -59,6 +60,28 @@ class Site:
info = json.loads(self.output('ip -j link show'))
return [i['ifname'] for i in info]
+ def ifup(self, ifname):
+ self.require_cmds('ip')
+ self.fg('ip link set {} up'.format(ifname), sudo=True)
+
+ def addrinfos(self, ifname, **filter):
+ self.require_cmds('ip')
+ info = json.loads(self.output('ip -j addr show {}'.format(ifname)))
+ assert len(info) == 1 # We specified a specific interface
+
+ ais = [ai for ai in info[0]['addr_info']]
+ for key, value in filter.items():
+ ais = [ai for ai in ais if key in ai and ai[key] == value]
+
+ return ais
+
+ def addrs(self, ifname, **filter):
+ self.require_cmds('ip')
+ # Return just the parsed, non-tentative addresses
+ return [ipaddress.ip_interface('{}/{}'.format(ai['local'], ai['prefixlen']))
+ for ai in self.addrinfos(ifname, **filter)
+ if not 'tentative' in ai]
+
class BaseSiteTasst(Tasst):
"""
@@ -105,6 +128,12 @@ class BaseSiteTasst(Tasst):
site = self.get_subsetup(BaseSiteTasst)
self.assertIn('lo', site.ifs())
+ def test_lo_addrs(self):
+ site = self.get_subsetup(BaseSiteTasst)
+ expected = [ipaddress.ip_interface(a)
+ for a in ['127.0.0.1/8', '::1/128']]
+ self.assertCountEqual(site.addrs('lo'), expected)
+
# Represents the host on which the tests are running, as opposed to
# some simulated host created by the tests
--
@@ -10,6 +10,7 @@
# Copyright Red Hat
# Author: David Gibson <david@gibson.dropbear.id.au>
+import ipaddress
import json
import avocado
@@ -59,6 +60,28 @@ class Site:
info = json.loads(self.output('ip -j link show'))
return [i['ifname'] for i in info]
+ def ifup(self, ifname):
+ self.require_cmds('ip')
+ self.fg('ip link set {} up'.format(ifname), sudo=True)
+
+ def addrinfos(self, ifname, **filter):
+ self.require_cmds('ip')
+ info = json.loads(self.output('ip -j addr show {}'.format(ifname)))
+ assert len(info) == 1 # We specified a specific interface
+
+ ais = [ai for ai in info[0]['addr_info']]
+ for key, value in filter.items():
+ ais = [ai for ai in ais if key in ai and ai[key] == value]
+
+ return ais
+
+ def addrs(self, ifname, **filter):
+ self.require_cmds('ip')
+ # Return just the parsed, non-tentative addresses
+ return [ipaddress.ip_interface('{}/{}'.format(ai['local'], ai['prefixlen']))
+ for ai in self.addrinfos(ifname, **filter)
+ if not 'tentative' in ai]
+
class BaseSiteTasst(Tasst):
"""
@@ -105,6 +128,12 @@ class BaseSiteTasst(Tasst):
site = self.get_subsetup(BaseSiteTasst)
self.assertIn('lo', site.ifs())
+ def test_lo_addrs(self):
+ site = self.get_subsetup(BaseSiteTasst)
+ expected = [ipaddress.ip_interface(a)
+ for a in ['127.0.0.1/8', '::1/128']]
+ self.assertCountEqual(site.addrs('lo'), expected)
+
# Represents the host on which the tests are running, as opposed to
# some simulated host created by the tests
--
2.40.1
next prev parent reply other threads:[~2023-05-16 2:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 2:01 [PATCH v2 00/21] RFCv2: Proof-of-concept conversion of some tests to Avocado framework David Gibson
2023-05-16 2:01 ` [PATCH v2 01/21] test/nstool: Provide useful error if given a path that's too long David Gibson
2023-05-16 2:01 ` [PATCH v2 02/21] test/nstool: Fix fd leak in accept() loop David Gibson
2023-05-16 2:01 ` [PATCH v2 03/21] avocado: Make a duplicate copy of testsuite for comparison purposes David Gibson
2023-05-16 2:01 ` [PATCH v2 04/21] avocado: Don't double download assets for test/ and oldtest/ David Gibson
2023-05-16 2:01 ` [PATCH v2 05/21] avocado: Move static checkers to avocado David Gibson
2023-05-16 2:01 ` [PATCH v2 06/21] avocado/tasst: Helper functions for executing commands in different places David Gibson
2023-05-16 2:01 ` [PATCH v2 07/21] avocado: Convert build tests to avocado David Gibson
2023-05-16 2:01 ` [PATCH v2 08/21] avocado/tasst: Add helpers for running background commands on sites David Gibson
2023-05-16 2:01 ` [PATCH v2 09/21] avocado/tasst: Add helper to get network interface names for a site David Gibson
2023-05-16 2:01 ` [PATCH v2 10/21] avocado/tasst: Add helpers to run commands with nstool David Gibson
2023-05-16 2:01 ` David Gibson [this message]
2023-05-16 2:01 ` [PATCH v2 12/21] avocado/tasst: Helper for creating veth devices between namespaces David Gibson
2023-05-16 2:01 ` [PATCH v2 13/21] avocado/tasst: Add helper for getting MTU of a network interface David Gibson
2023-05-16 2:01 ` [PATCH v2 14/21] avocado/tasst: Add helper to wait for IP address to appear David Gibson
2023-05-16 2:01 ` [PATCH v2 15/21] avocado/tasst: Add helpers for getting a site's routes David Gibson
2023-05-16 2:01 ` [PATCH v2 16/21] avocado/tasst: Helpers for test transferring data between sites David Gibson
2023-05-16 2:01 ` [PATCH v2 17/21] avocado/tasst: IP address allocation helpers David Gibson
2023-05-16 2:01 ` [PATCH v2 18/21] avocado/tasst: Helpers for testing NDP behaviour David Gibson
2023-05-16 2:01 ` [PATCH v2 19/21] avocado/tasst: Helpers for testing DHCP & DHCPv6 behaviour David Gibson
2023-05-16 2:01 ` [PATCH v2 20/21] avocado/tasst: Helpers to construct a simple network environment for tests David Gibson
2023-05-16 2:01 ` [PATCH v2 21/21] avocado: Convert basic pasta tests David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516020135.1901256-12-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=crosa@redhat.com \
--cc=jarichte@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).