From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Callum Parsey <callum@neoninteger.au>,
me@yawnt.com, lemmi@nerd2nerd.org,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v2 07/10] conf: Don't exit if sourced default route has no gateway
Date: Mon, 22 May 2023 17:29:59 +0200 [thread overview]
Message-ID: <20230522172959.4703f517@elisabeth> (raw)
In-Reply-To: <ZGssZ5vYyxXnerQQ@yekko>
On Mon, 22 May 2023 18:48:39 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Mon, May 22, 2023 at 01:42:21AM +0200, Stefano Brivio wrote:
> > If we use a template interface without a gateway on the default
> > route, we can still offer almost complete functionality, except that,
> > of course, we can't map the gateway address to the outer namespace or
> > host, and that we have no obvious server address or identifier for
> > use in DHCP's siaddr and option 54 (Server identifier, mandatory).
> >
> > Continue, if we have a default route but no default gateway, and
> > imply --no-map-gw and --no-dhcp in that case. NDP responder and
> > DHCPv6 should be able to work as usual because we require a
> > link-local address to be present, and we'll fall back to that.
>
> Implying (rather than requiring) --no-map-gw and --no-dhcp does worry
> me a bit. I feel like it might violate the principle of least
> surprise.
Well, yes, but on the other hand it risks to be a lot of typing (and
changes to the Podman integration) for a relatively common setup. And
we might even figure out there's a way and a benefit to re-enable DHCP
support in this case.
I'm not fond of that either, but I still prefer it to the alternative.
--
Stefano
next prev parent reply other threads:[~2023-05-22 15:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 23:42 [PATCH v2 00/10] Optionally copy all routes and addresses for pasta, allow gateway-less routes Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 01/10] netlink: Fix comment about response buffer size for nl_req() Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 02/10] pasta: Improve error handling on failure to join network namespace Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 03/10] netlink: Add functionality to copy routes from outer namespace Stefano Brivio
2023-05-22 8:42 ` David Gibson
2023-05-22 9:58 ` Stefano Brivio
2023-05-23 3:08 ` David Gibson
2023-05-23 6:14 ` Stefano Brivio
2023-05-27 2:06 ` David Gibson
2023-05-21 23:42 ` [PATCH v2 04/10] conf: --config-net option is for pasta mode only Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 05/10] conf, pasta: With --config-net, copy all routes by default Stefano Brivio
2023-05-22 8:44 ` David Gibson
2023-05-22 9:59 ` Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 06/10] Revert "conf: Adjust netmask on mismatch between IPv4 address/netmask and gateway" Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 07/10] conf: Don't exit if sourced default route has no gateway Stefano Brivio
2023-05-22 8:48 ` David Gibson
2023-05-22 15:29 ` Stefano Brivio [this message]
2023-05-21 23:42 ` [PATCH v2 08/10] netlink: Add functionality to copy addresses from outer namespace Stefano Brivio
2023-05-22 8:51 ` David Gibson
2023-05-21 23:42 ` [PATCH v2 09/10] conf, pasta: With --config-net, copy all addresses by default Stefano Brivio
2023-05-22 8:53 ` David Gibson
2023-05-22 15:30 ` Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 10/10] passt.h: Fix description of pasta_ifi in struct ctx Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522172959.4703f517@elisabeth \
--to=sbrivio@redhat.com \
--cc=aarcange@redhat.com \
--cc=callum@neoninteger.au \
--cc=david@gibson.dropbear.id.au \
--cc=lemmi@nerd2nerd.org \
--cc=me@yawnt.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).