From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Callum Parsey <callum@neoninteger.au>,
me@yawnt.com, lemmi@nerd2nerd.org,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH v2 09/10] conf, pasta: With --config-net, copy all addresses by default
Date: Mon, 22 May 2023 17:30:08 +0200 [thread overview]
Message-ID: <20230522173008.0d2010a8@elisabeth> (raw)
In-Reply-To: <ZGstj+3tmGJJDrjl@yekko>
On Mon, 22 May 2023 18:53:35 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> On Mon, May 22, 2023 at 01:42:23AM +0200, Stefano Brivio wrote:
> > Use the newly-introduced NL_DUP mode for nl_addr() to copy all the
> > addresses associated to the template interface in the outer
> > namespace, unless --no-copy-addrs (also implied by -a) is given.
>
> Again, I'm always concerned by the addition of new command line
> options. Particularly in this case, where it looks like you can get
> the same behaviour by using the right -a option.
As discussed earlier: --no-copy-addrs is probably even less useful than
--no-copy-routes, but, even here, it would be nice to keep these
options around for a while as we're changing the default behaviour
(while "removing" nothing from it) -- especially if this causes an
issue, it's quite convenient to have a single option to restore the old
behaviour for investigation.
So let's add those options as deprecated right away, and then we can
drop them in a couple of months if everything goes as expected. I'll
respin in a bit.
--
Stefano
next prev parent reply other threads:[~2023-05-22 15:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 23:42 [PATCH v2 00/10] Optionally copy all routes and addresses for pasta, allow gateway-less routes Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 01/10] netlink: Fix comment about response buffer size for nl_req() Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 02/10] pasta: Improve error handling on failure to join network namespace Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 03/10] netlink: Add functionality to copy routes from outer namespace Stefano Brivio
2023-05-22 8:42 ` David Gibson
2023-05-22 9:58 ` Stefano Brivio
2023-05-23 3:08 ` David Gibson
2023-05-23 6:14 ` Stefano Brivio
2023-05-27 2:06 ` David Gibson
2023-05-21 23:42 ` [PATCH v2 04/10] conf: --config-net option is for pasta mode only Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 05/10] conf, pasta: With --config-net, copy all routes by default Stefano Brivio
2023-05-22 8:44 ` David Gibson
2023-05-22 9:59 ` Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 06/10] Revert "conf: Adjust netmask on mismatch between IPv4 address/netmask and gateway" Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 07/10] conf: Don't exit if sourced default route has no gateway Stefano Brivio
2023-05-22 8:48 ` David Gibson
2023-05-22 15:29 ` Stefano Brivio
2023-05-21 23:42 ` [PATCH v2 08/10] netlink: Add functionality to copy addresses from outer namespace Stefano Brivio
2023-05-22 8:51 ` David Gibson
2023-05-21 23:42 ` [PATCH v2 09/10] conf, pasta: With --config-net, copy all addresses by default Stefano Brivio
2023-05-22 8:53 ` David Gibson
2023-05-22 15:30 ` Stefano Brivio [this message]
2023-05-21 23:42 ` [PATCH v2 10/10] passt.h: Fix description of pasta_ifi in struct ctx Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230522173008.0d2010a8@elisabeth \
--to=sbrivio@redhat.com \
--cc=aarcange@redhat.com \
--cc=callum@neoninteger.au \
--cc=david@gibson.dropbear.id.au \
--cc=lemmi@nerd2nerd.org \
--cc=me@yawnt.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).