From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 204345A027F for ; Mon, 22 May 2023 17:30:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684769416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uTBA6cXtGXjPm2pTA+oPRnKWHKwtPOUged2NrZeSbcY=; b=VspIOUY1EX2BeS1CMcX1Y13jzrfF3zs1FXbasMxyiROuOf7GlaDo+/Hy4xTBFDubKuI2q2 CDdXZRi3nGEODQIAzCTy+yCfs55hduPTTAwPmMYfcm/ze/8lSyR/2NtiM3L9+aHBfYCvCR oHkOjY6JsjEVJlTGl+ODnWoCgHvDI8Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-269-xFiVy1UiNv2Sg3EwG3olGw-1; Mon, 22 May 2023 11:30:13 -0400 X-MC-Unique: xFiVy1UiNv2Sg3EwG3olGw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 844E9801182; Mon, 22 May 2023 15:30:12 +0000 (UTC) Received: from elisabeth (unknown [10.39.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 240501121314; Mon, 22 May 2023 15:30:10 +0000 (UTC) Date: Mon, 22 May 2023 17:30:08 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 09/10] conf, pasta: With --config-net, copy all addresses by default Message-ID: <20230522173008.0d2010a8@elisabeth> In-Reply-To: References: <20230521234224.2770015-1-sbrivio@redhat.com> <20230521234224.2770015-10-sbrivio@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: R4UFXIRK4XEBENEZO2BHWGP3YRPULM7O X-Message-ID-Hash: R4UFXIRK4XEBENEZO2BHWGP3YRPULM7O X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Callum Parsey , me@yawnt.com, lemmi@nerd2nerd.org, Andrea Arcangeli X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 22 May 2023 18:53:35 +1000 David Gibson wrote: > On Mon, May 22, 2023 at 01:42:23AM +0200, Stefano Brivio wrote: > > Use the newly-introduced NL_DUP mode for nl_addr() to copy all the > > addresses associated to the template interface in the outer > > namespace, unless --no-copy-addrs (also implied by -a) is given. > > Again, I'm always concerned by the addition of new command line > options. Particularly in this case, where it looks like you can get > the same behaviour by using the right -a option. As discussed earlier: --no-copy-addrs is probably even less useful than --no-copy-routes, but, even here, it would be nice to keep these options around for a while as we're changing the default behaviour (while "removing" nothing from it) -- especially if this causes an issue, it's quite convenient to have a single option to restore the old behaviour for investigation. So let's add those options as deprecated right away, and then we can drop them in a couple of months if everything goes as expected. I'll respin in a bit. -- Stefano