From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: Cleber Rosa <crosa@redhat.com>,
jarichte@redhat.com, David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v3 07/20] avocado/tasst: Add helpers for running background commands on sites
Date: Wed, 31 May 2023 11:58:36 +1000 [thread overview]
Message-ID: <20230531015849.3229596-8-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20230531015849.3229596-1-david@gibson.dropbear.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
avocado/tasst/site.py | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/avocado/tasst/site.py b/avocado/tasst/site.py
index 415a953..6aa83c4 100644
--- a/avocado/tasst/site.py
+++ b/avocado/tasst/site.py
@@ -40,6 +40,9 @@ class Site(contextlib.AbstractContextManager):
def fg(self, cmd, **kwargs):
self.output(cmd, **kwargs)
+ def bg(self, cmd, **kwargs):
+ raise NotImplementedError
+
def require_cmds(self, *cmds):
missing = [c for c in cmds
if self.fg('type {}'.format(c), ignore_status=True) != 0]
@@ -75,6 +78,18 @@ class SiteTasst(Tasst):
out = site.output('echo {}'.format(s))
self.assertEquals(out, s.encode('utf-8'))
+ def test_bg_true(self):
+ with self.setup_site() as site:
+ with site.bg('true') as proc:
+ status = proc.wait()
+ self.assertEquals(status, 0)
+
+ def test_bg_false(self):
+ with self.setup_site() as site:
+ with site.bg('false') as proc:
+ status = proc.wait()
+ self.assertNotEquals(status, 0)
+
# Represents the host on which the tests are running, as opposed to
# some simulated host created by the tests
@@ -96,6 +111,16 @@ class RealHost(Site):
assert not sudo, "BUG: Shouldn't run commands with privilege on host"
return avocado.utils.process.system(cmd, **kwargs)
+ @contextlib.contextmanager
+ def bg(self, cmd, sudo=False, **kwargs):
+ assert not sudo, "BUG: Shouldn't run commands with privilege on host"
+ try:
+ proc = avocado.utils.process.SubProcess(cmd, **kwargs)
+ proc.start()
+ yield proc
+ finally:
+ proc.stop()
+
REAL_HOST = RealHost()
--
@@ -40,6 +40,9 @@ class Site(contextlib.AbstractContextManager):
def fg(self, cmd, **kwargs):
self.output(cmd, **kwargs)
+ def bg(self, cmd, **kwargs):
+ raise NotImplementedError
+
def require_cmds(self, *cmds):
missing = [c for c in cmds
if self.fg('type {}'.format(c), ignore_status=True) != 0]
@@ -75,6 +78,18 @@ class SiteTasst(Tasst):
out = site.output('echo {}'.format(s))
self.assertEquals(out, s.encode('utf-8'))
+ def test_bg_true(self):
+ with self.setup_site() as site:
+ with site.bg('true') as proc:
+ status = proc.wait()
+ self.assertEquals(status, 0)
+
+ def test_bg_false(self):
+ with self.setup_site() as site:
+ with site.bg('false') as proc:
+ status = proc.wait()
+ self.assertNotEquals(status, 0)
+
# Represents the host on which the tests are running, as opposed to
# some simulated host created by the tests
@@ -96,6 +111,16 @@ class RealHost(Site):
assert not sudo, "BUG: Shouldn't run commands with privilege on host"
return avocado.utils.process.system(cmd, **kwargs)
+ @contextlib.contextmanager
+ def bg(self, cmd, sudo=False, **kwargs):
+ assert not sudo, "BUG: Shouldn't run commands with privilege on host"
+ try:
+ proc = avocado.utils.process.SubProcess(cmd, **kwargs)
+ proc.start()
+ yield proc
+ finally:
+ proc.stop()
+
REAL_HOST = RealHost()
--
2.40.1
next prev parent reply other threads:[~2023-05-31 1:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 1:58 [PATCH v3 00/20] RFCv3: Proof-of-concept conversion of some tests to Avocado framework David Gibson
2023-05-30 23:59 ` [PATCH v3 01/20] avocado: Make a duplicate copy of testsuite for comparison purposes David Gibson
2023-05-31 1:58 ` [PATCH v3 02/20] avocado: Don't double download assets for test/ and oldtest/ David Gibson
2023-05-31 1:58 ` [PATCH v3 03/20] avocado: Move static checkers to avocado David Gibson
2023-05-31 1:58 ` [PATCH v3 04/20] avocado/tasst: Helper functions for executing commands in different places David Gibson
2023-05-31 1:58 ` [PATCH v3 05/20] avocado/tasst: Type checking helpers David Gibson
2023-05-31 1:58 ` [PATCH v3 06/20] avocado: Convert build tests to avocado David Gibson
2023-05-31 1:58 ` David Gibson [this message]
2023-05-31 1:58 ` [PATCH v3 08/20] avocado/tasst: Add helper to get network interface names for a site David Gibson
2023-05-31 1:58 ` [PATCH v3 09/20] avocado/tasst: Add helpers to run commands with nstool David Gibson
2023-05-31 1:58 ` [PATCH v3 10/20] avocado/tasst: Add ifup and network address helpers to Site David Gibson
2023-05-31 1:58 ` [PATCH v3 11/20] avocado/tasst: Helper for creating veth devices between namespaces David Gibson
2023-05-31 1:58 ` [PATCH v3 12/20] avocado/tasst: Add helper for getting MTU of a network interface David Gibson
2023-05-31 1:58 ` [PATCH v3 13/20] avocado/tasst: Add helper to wait for IP address to appear David Gibson
2023-05-31 1:58 ` [PATCH v3 14/20] avocado/tasst: Add helpers for getting a site's routes David Gibson
2023-05-31 1:58 ` [PATCH v3 15/20] avocado/tasst: Helpers for test transferring data between sites David Gibson
2023-05-31 1:58 ` [PATCH v3 16/20] avocado/tasst: IP address allocation helpers David Gibson
2023-05-31 1:58 ` [PATCH v3 17/20] avocado/tasst: Helpers for testing NDP behaviour David Gibson
2023-05-31 1:58 ` [PATCH v3 18/20] avocado/tasst: Helpers for testing DHCP & DHCPv6 behaviour David Gibson
2023-05-31 1:58 ` [PATCH v3 19/20] avocado/tasst: Helpers to construct a simple network environment for tests David Gibson
2023-05-31 1:58 ` [PATCH v3 20/20] avocado: Convert basic pasta tests David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531015849.3229596-8-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=crosa@redhat.com \
--cc=jarichte@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).