From: Paul Holzinger <pholzing@redhat.com>
To: passt-dev@passt.top
Cc: Paul Holzinger <pholzing@redhat.com>
Subject: [PATCH] isolation: keep CAP_SYS_PTRACE when required
Date: Fri, 23 Jun 2023 10:25:32 +0200 [thread overview]
Message-ID: <20230623082531.25947-2-pholzing@redhat.com> (raw)
When pasta is started from an existing userns and tries to join the
netns from another process it fails to open /proc/$pid/ns/net due the
missing CAP_SYS_PTRACE capability in the --netns-only case.
A simple reproducer for this.
First create a userns:
$ unshare -r
Then create a new netns inside it and try to join that netns with pasta.
$ unshare -n sleep inf &
$ pasta --config-net --netns /proc/$!/ns/net
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
---
isolation.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/isolation.c b/isolation.c
index 19932bf..1866724 100644
--- a/isolation.c
+++ b/isolation.c
@@ -202,9 +202,11 @@ void isolate_initial(void)
* a mapping from UID 0, which only happens with pasta spawning a child
* from a non-init user namespace (pasta can't run as root), we need to
* retain CAP_SETFCAP too.
+ * We also need to keep CAP_SYS_PTRACE in order to join an existing netns
+ * path under /proc/$pid/ns/net which was created in the same userns.
*/
if (!ns_is_init() && !geteuid())
- keep |= BIT(CAP_SETFCAP);
+ keep |= BIT(CAP_SETFCAP) | BIT(CAP_SYS_PTRACE);
drop_caps_ep_except(keep);
}
--
@@ -202,9 +202,11 @@ void isolate_initial(void)
* a mapping from UID 0, which only happens with pasta spawning a child
* from a non-init user namespace (pasta can't run as root), we need to
* retain CAP_SETFCAP too.
+ * We also need to keep CAP_SYS_PTRACE in order to join an existing netns
+ * path under /proc/$pid/ns/net which was created in the same userns.
*/
if (!ns_is_init() && !geteuid())
- keep |= BIT(CAP_SETFCAP);
+ keep |= BIT(CAP_SETFCAP) | BIT(CAP_SYS_PTRACE);
drop_caps_ep_except(keep);
}
--
2.41.0
next reply other threads:[~2023-06-23 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 8:25 Paul Holzinger [this message]
2023-06-26 7:22 ` [PATCH] isolation: keep CAP_SYS_PTRACE when required Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623082531.25947-2-pholzing@redhat.com \
--to=pholzing@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).